Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: chrome/browser/extensions/extension_tab_util.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.h ('k') | chrome/browser/extensions/window_controller_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tab_util.cc
diff --git a/chrome/browser/extensions/extension_tab_util.cc b/chrome/browser/extensions/extension_tab_util.cc
index 1537a33e8ed4d0b4f06d9a57fcd96724029f4ca0..70414418d0d4f1d817d9bde12392bf73faec0b84 100644
--- a/chrome/browser/extensions/extension_tab_util.cc
+++ b/chrome/browser/extensions/extension_tab_util.cc
@@ -87,7 +87,7 @@ Browser* GetBrowserInProfileWithId(Profile* profile,
return NULL;
}
-Browser* CreateBrowser(ChromeAsyncExtensionFunction* function,
+Browser* CreateBrowser(ChromeUIThreadExtensionFunction* function,
int window_id,
std::string* error) {
content::WebContents* web_contents = function->GetAssociatedWebContents();
@@ -118,7 +118,7 @@ ExtensionTabUtil::OpenTabParams::~OpenTabParams() {
// Opens a new tab for a given extension. Returns NULL and sets |error| if an
// error occurs.
base::DictionaryValue* ExtensionTabUtil::OpenTab(
- ChromeAsyncExtensionFunction* function,
+ ChromeUIThreadExtensionFunction* function,
const OpenTabParams& params,
std::string* error) {
// windowId defaults to "current" window.
@@ -257,7 +257,7 @@ base::DictionaryValue* ExtensionTabUtil::OpenTab(
}
Browser* ExtensionTabUtil::GetBrowserFromWindowID(
- ChromeAsyncExtensionFunction* function,
+ ChromeUIThreadExtensionFunction* function,
int window_id,
std::string* error) {
if (window_id == extension_misc::kCurrentWindowId) {
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.h ('k') | chrome/browser/extensions/window_controller_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698