chrome/browser/extensions/extension_function_test_utils.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_test_utils.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix comment Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function_test_utils.cc

diff --git a/chrome/browser/extensions/extension_function_test_utils.cc b/chrome/browser/extensions/extension_function_test_utils.cc

index e7de2472a2db359b5e65c0c319ffeeef3dde64ed..94951caac12dcd283f461ce67201d777abf1f630 100644

--- a/chrome/browser/extensions/extension_function_test_utils.cc

+++ b/chrome/browser/extensions/extension_function_test_utils.cc

@@ -257,9 +257,9 @@ bool RunFunction(UIThreadExtensionFunction* function,

function->set_browser_context(browser->profile());

function->set_include_incognito(flags & INCLUDE_INCOGNITO);

- function->Run();

+ function->Run()->Execute();

- // If the RunImpl of |function| didn't already call SendResponse, run the

+ // If the RunAsync of |function| didn't already call SendResponse, run the

// message loop until they do.

if (!response_delegate.HasResponse()) {

response_delegate.set_should_post_quit(true);