|
|
Revert of [DevTools] Remove methods on Common.Event. (patchset #4 id:60001 of https://codereview.chromium.org/2553043003/ )
Reason for revert:
Compromises the ability to add new watch expressions and XHR Breakpoints.
In the debugger sidepane, Watch Expressions and XHR sections have a '+' icon when open. Clicking on the '+' should add a new entry, but instead it closes the section.
Original issue's description:
> [DevTools] Remove methods on Common.Event.
>
> Patch removes preventDefault(), stopPropagation(), consume() and .type property.
> This is a preparation for typed events, which will not inherit from Common.Event.
>
> BUG=none
>
> Committed: https://crrev.com/cd3e789d9ae61c3028d05d9e3361198496b45412
> Cr-Commit-Position: refs/heads/master@{#437987}
TBR=lushnikov@chromium.org,dgozman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=none
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+205 lines, -270 lines) |
Patch |
 |
M |
third_party/WebKit/LayoutTests/http/tests/inspector/network/font-face.html
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/http/tests/inspector/network/font-face-expected.txt
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-test.js
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js
|
View
|
|
7 chunks |
+17 lines, -14 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/common/Object.js
|
View
|
|
3 chunks |
+33 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/components/DockController.js
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
|
View
|
|
4 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/EventListenersWidget.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
|
View
|
|
7 chunks |
+11 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/layer_viewer/TransformController.js
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/main/Main.js
|
View
|
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotProxy.js
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js
|
View
|
|
4 chunks |
+3 lines, -12 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
|
View
|
|
4 chunks |
+5 lines, -14 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js
|
View
|
|
7 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js
|
View
|
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
|
View
|
|
4 chunks |
+6 lines, -18 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
|
View
|
|
3 chunks |
+5 lines, -14 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkersView.js
|
View
|
|
2 chunks |
+8 lines, -20 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/screencast/ScreencastApp.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
|
View
|
|
3 chunks |
+3 lines, -9 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
|
View
|
|
2 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
|
View
|
|
3 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
|
View
|
|
2 chunks |
+16 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
|
View
|
|
2 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
|
View
|
|
4 chunks |
+8 lines, -13 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js
|
View
|
|
4 chunks |
+3 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js
|
View
|
|
2 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
Total messages: 14 (7 generated)
|