Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Spectrum.js

Issue 2573323002: Revert of [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js b/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
index c714b4a8d0bb8762c5991a4baced524f836e3e2d..30a63a3462dd2fb4a99a386666f3fd00dff4e4c3 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
@@ -58,8 +58,7 @@
var toolbar = new UI.Toolbar('spectrum-eye-dropper', this.contentElement);
this._colorPickerButton = new UI.ToolbarToggle(Common.UIString('Toggle color picker'), 'largeicon-eyedropper');
this._colorPickerButton.setToggled(true);
- this._colorPickerButton.addEventListener(
- UI.ToolbarButton.Events.Click, this._toggleColorPicker.bind(this, undefined));
+ this._colorPickerButton.addEventListener('click', this._toggleColorPicker.bind(this, undefined));
toolbar.appendToolbarItem(this._colorPickerButton);
var swatchElement = this.contentElement.createChild('span', 'swatch');
@@ -137,7 +136,7 @@
this._addColorToolbar = new UI.Toolbar('add-color-toolbar');
var addColorButton = new UI.ToolbarButton(Common.UIString('Add to palette'), 'largeicon-add');
- addColorButton.addEventListener(UI.ToolbarButton.Events.Click, this._addColorToCustomPalette, this);
+ addColorButton.addEventListener('click', this._addColorToCustomPalette.bind(this));
this._addColorToolbar.appendToolbarItem(addColorButton);
this._loadPalettes();
@@ -209,7 +208,7 @@
title.textContent = Common.UIString('Color Palettes');
var toolbar = new UI.Toolbar('', this._palettePanel);
var closeButton = new UI.ToolbarButton('Return to color picker', 'largeicon-delete');
- closeButton.addEventListener(UI.ToolbarButton.Events.Click, this._togglePalettePanel.bind(this, false));
+ closeButton.addEventListener('click', this._togglePalettePanel.bind(this, false));
toolbar.appendToolbarItem(closeButton);
for (var palette of this._palettes.values())
this._palettePanel.appendChild(this._createPreviewPaletteElement(palette));
@@ -525,10 +524,7 @@
Components.Spectrum._ChangeSource.Other);
}
- /**
- * @param {!Common.Event} event
- */
- _addColorToCustomPalette(event) {
+ _addColorToCustomPalette() {
var palette = this._customPaletteSetting.get();
palette.colors.push(this.colorString());
this._customPaletteSetting.set(palette);

Powered by Google App Engine
This is Rietveld 408576698