third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js - Issue 2573323002: Revert of [DevTools] Remove methods on Common.Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

Issue 2573323002: Revert of [DevTools] Remove methods on Common.Event. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

index 1b5f819b1113183beefdb5a39ef169559389432b..3b0192f32b416a2e735a247cc1eb73efa1a16742 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -282,7 +282,7 @@

if (Runtime.experiments.isEnabled('timelineRecordingPerspectives') &&

perspectiveSetting.get() === Timeline.TimelinePanel.Perspectives.Load) {

this._reloadButton = new UI.ToolbarButton(Common.UIString('Record & Reload'), 'largeicon-refresh');

- this._reloadButton.addEventListener(UI.ToolbarButton.Events.Click, () => SDK.targetManager.reloadPage());

+ this._reloadButton.addEventListener('click', () => SDK.targetManager.reloadPage());

this._panelToolbar.appendToolbarItem(this._reloadButton);

} else {

this._panelToolbar.appendToolbarItem(UI.Toolbar.createActionButton(this._toggleRecordAction));

@@ -290,7 +290,7 @@

// Clear

var clearButton = new UI.ToolbarButton(Common.UIString('Clear recording'), 'largeicon-clear');

- clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._clear, this);

+ clearButton.addEventListener('click', this._clear, this);

this._panelToolbar.appendToolbarItem(clearButton);

this._panelToolbar.appendSeparator();