Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2573283002: Use a static catalog manifest for the standalone Mash runner (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, kalyank, qsr+mojo_chromium.org, sadrul, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a static catalog manifest for the standalone Mash runner Does a few interesting things: - Teaches Catalog how to load its data from a static dictionary in memory - Adds GNI for generating catalog manifest JSON - Adds a catalog of common mash services - Deletes mojo_runner - Introduces //mash/runner (executable "mash") which does the same thing mojo_runner did, but has baked-in knowledge of the mash catalog. BUG=677194 R=ben@chromium.org Committed: https://crrev.com/c4146735e6d1dffea9a014e6f89bd6fc57de53d1 Cr-Commit-Position: refs/heads/master@{#440802}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : rebase #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : rebase, fix dll override race #

Patch Set 8 : rebase #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -356 lines) Patch
M chrome/app/mash/BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/mash/mash_service_overrides.json View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_manager/service_manager_context.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M mash/BUILD.gn View 1 2 3 4 5 6 7 8 3 chunks +75 lines, -0 lines 0 comments Download
M mash/example/BUILD.gn View 2 chunks +16 lines, -1 line 0 comments Download
A mash/runner/BUILD.gn View 1 1 chunk +24 lines, -0 lines 0 comments Download
A mash/runner/main.cc View 1 2 3 4 5 6 7 1 chunk +90 lines, -0 lines 0 comments Download
M services/catalog/catalog.h View 5 chunks +7 lines, -6 lines 0 comments Download
M services/catalog/catalog.cc View 1 2 3 4 5 6 7 3 chunks +11 lines, -12 lines 0 comments Download
M services/catalog/instance.h View 5 chunks +3 lines, -21 lines 0 comments Download
M services/catalog/instance.cc View 5 chunks +4 lines, -63 lines 0 comments Download
A services/catalog/public/tools/catalog.gni View 1 chunk +94 lines, -0 lines 0 comments Download
A services/catalog/public/tools/generate_manifest.py View 1 chunk +97 lines, -0 lines 0 comments Download
M services/catalog/reader.h View 3 chunks +6 lines, -0 lines 0 comments Download
M services/catalog/reader.cc View 1 2 3 9 chunks +113 lines, -8 lines 0 comments Download
M services/catalog/store.h View 2 chunks +2 lines, -19 lines 0 comments Download
M services/service_manager/background/BUILD.gn View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/background/background_service_manager.h View 1 2 3 4 5 6 7 2 chunks +1 line, -5 lines 0 comments Download
M services/service_manager/background/background_service_manager.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M services/service_manager/public/interfaces/resolver.mojom View 1 chunk +6 lines, -3 lines 0 comments Download
M services/service_manager/runner/host/service_process_launcher.cc View 1 2 3 4 5 6 2 chunks +0 lines, -24 lines 0 comments Download
M services/service_manager/service_manager.cc View 1 2 3 4 5 6 7 2 chunks +11 lines, -1 line 0 comments Download
M services/service_manager/service_overrides.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/service_manager/standalone/BUILD.gn View 1 2 chunks +5 lines, -34 lines 0 comments Download
M services/service_manager/standalone/context.h View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M services/service_manager/standalone/context.cc View 1 2 3 4 5 6 7 1 chunk +7 lines, -5 lines 0 comments Download
D services/service_manager/standalone/desktop/launcher_process.h View 1 chunk +0 lines, -17 lines 0 comments Download
D services/service_manager/standalone/desktop/launcher_process.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D services/service_manager/standalone/desktop/main.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D services/service_manager/standalone/desktop/main_helper.h View 1 chunk +0 lines, -15 lines 0 comments Download
D services/service_manager/standalone/desktop/main_helper.cc View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 63 (50 generated)
Ken Rockot(use gerrit already)
4 years ago (2016-12-16 21:17:40 UTC) #17
Ben Goodger (Google)
lgtm
4 years ago (2016-12-16 22:47:48 UTC) #18
Ken Rockot(use gerrit already)
+tsepez@ for mojom change
4 years ago (2016-12-16 23:22:15 UTC) #21
Tom Sepez
lgtm
4 years ago (2016-12-16 23:35:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573283002/60001
4 years ago (2016-12-16 23:53:24 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/140657)
4 years ago (2016-12-17 00:37:52 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573283002/60001
4 years ago (2016-12-17 01:26:45 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/140716)
4 years ago (2016-12-17 01:33:12 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573283002/100001
4 years ago (2016-12-17 08:32:06 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/335199)
4 years ago (2016-12-17 08:55:57 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573283002/160001
3 years, 11 months ago (2016-12-27 23:17:41 UTC) #58
commit-bot: I haz the power
Committed patchset #9 (id:160001)
3 years, 11 months ago (2016-12-27 23:22:20 UTC) #61
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:44 UTC) #63
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/c4146735e6d1dffea9a014e6f89bd6fc57de53d1
Cr-Commit-Position: refs/heads/master@{#440802}

Powered by Google App Engine
This is Rietveld 408576698