Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: services/service_manager/service_manager.cc

Issue 2573283002: Use a static catalog manifest for the standalone Mash runner (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/service_manager/service_manager.cc
diff --git a/services/service_manager/service_manager.cc b/services/service_manager/service_manager.cc
index 9b6fb5441f959222334819574eff75cd480a7a98..acfcaaf51e02febad62ea28dac2cf44aa890440b 100644
--- a/services/service_manager/service_manager.cc
+++ b/services/service_manager/service_manager.cc
@@ -672,7 +672,7 @@ void ServiceManager::Connect(std::unique_ptr<ConnectParams> params,
service_manager::mojom::kServiceName, params->target().user_id()));
std::string name = params->target().name();
- resolver->ResolveMojoName(
+ resolver->ResolveServiceName(
name,
base::Bind(&service_manager::ServiceManager::OnGotResolvedName,
weak_ptr_factory_.GetWeakPtr(), base::Passed(&params),
@@ -820,6 +820,16 @@ void ServiceManager::OnGotResolvedName(std::unique_ptr<ConnectParams> params,
if (has_source_instance && !source_instance)
return;
+ // If name resolution failed, we drop the connection.
+ if (!result) {
+ LOG(ERROR) << "Failed to resolve service name: " << params->target().name();
+ if (!params->connect_callback().is_null()) {
+ params->connect_callback().Run(
+ mojom::ConnectResult::INVALID_ARGUMENT, "");
+ }
+ return;
+ }
+
std::string instance_name = params->target().instance();
if (instance_name == params->target().name() &&
result->qualifier != result->resolved_name) {
« no previous file with comments | « services/service_manager/runner/host/service_process_launcher.cc ('k') | services/service_manager/service_overrides.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698