Don't hold on to the adapter position during a dismissal animation.

[Android NTP] Don't hold on to the adapter position during a dismissal animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709
Committed: https://crrev.com/7d85923117fbe38350e7022f6003d37b58b013f2
Cr-Commit-Position: refs/heads/master@{#438493}

[Bernhard Bauer, 2016-12-14 11:22:25]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 11:22:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-12-14 11:24:06]

Description was changed from

==========
Don't hold on to the adapter position during a dismissal animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

BUG=673709
==========

to

==========
Don't hold on to the adapter position during a dismissal animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709
==========

[Bernhard Bauer, 2016-12-14 11:24:26]

Description was changed from

==========
Don't hold on to the adapter position during a dismissal animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709
==========

to

==========
[Android NTP] Don't hold on to the adapter position during a dismissal
animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709
==========

[Bernhard Bauer, 2016-12-14 11:25:40]

bauerb@chromium.org changed reviewers:
+ dgn@chromium.org

[Bernhard Bauer, 2016-12-14 11:25:40]

Please review!

[commit-bot: I haz the power, 2016-12-14 11:56:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 11:56:07]

Dry run: This issue passed the CQ dry run.

[dgn, 2016-12-14 12:12:49]

lgtm

[Bernhard Bauer, 2016-12-14 12:53:37]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2016-12-14 12:53:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 12:57:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481720017149300, "parent_rev":
"17e32c61dd61651ba101c6e13fbcd1cc135e3bf9", "commit_rev":
"7e968583b35973a0609961adb620a0ddb52a4146"}

[commit-bot: I haz the power, 2016-12-14 12:57:47]

Description was changed from

==========
[Android NTP] Don't hold on to the adapter position during a dismissal
animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709
==========

to

==========
[Android NTP] Don't hold on to the adapter position during a dismissal
animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709

Review-Url: https://codereview.chromium.org/2573053002
==========

[commit-bot: I haz the power, 2016-12-14 12:57:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-14 13:00:56]

Description was changed from

==========
[Android NTP] Don't hold on to the adapter position during a dismissal
animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709

Review-Url: https://codereview.chromium.org/2573053002
==========

to

==========
[Android NTP] Don't hold on to the adapter position during a dismissal
animation.

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709

Committed: https://crrev.com/7d85923117fbe38350e7022f6003d37b58b013f2
Cr-Commit-Position: refs/heads/master@{#438493}
==========

[commit-bot: I haz the power, 2016-12-14 13:00:57]

Patchset 1 (id:??) landed as
https://crrev.com/7d85923117fbe38350e7022f6003d37b58b013f2
Cr-Commit-Position: refs/heads/master@{#438493}