chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java - Issue 2573053002: Don't hold on to the adapter position during a dismissal animation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

Issue 2573053002: Don't hold on to the adapter position during a dismissal animation. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

index fa3454bde6df003f45e56ec7c5f9a073d0a50f1d..3d6c70be4c444235ffea705d1614ee91ca577f63 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java

@@ -29,7 +29,7 @@ public abstract class InnerNode extends ChildNode implements NodeParent {

numItems += children.get(i).getItemCount();

if (position < numItems) return i;

}

- return -1;

+ throw new IndexOutOfBoundsException(position + "/" + numItems);

}

private int getStartingOffsetForChildIndex(int childIndex) {

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java » ('j') | no next file with comments »