Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2573013002: Add inheritance support to Webmodules template. (Closed)

Created:
4 years ago by dglazkov
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add inheritance support to Webmodules template. BUG=654129 R=bashi,peria Committed: https://crrev.com/5406d40da936510622cdfe5e64756006ebdc0189 Cr-Commit-Position: refs/heads/master@{#438521}

Patch Set 1 #

Patch Set 2 : Whoops, forgot 'public'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py View 1 2 chunks +23 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py View 1 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
dglazkov
Whoops, forgot 'public'.
4 years ago (2016-12-14 05:13:50 UTC) #3
dglazkov
PTAL.
4 years ago (2016-12-14 05:19:10 UTC) #6
haraken
LGTM
4 years ago (2016-12-14 05:21:52 UTC) #7
peria
lgtm
4 years ago (2016-12-14 05:41:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2573013002/20001
4 years ago (2016-12-14 15:19:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-14 15:23:08 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-14 15:27:19 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5406d40da936510622cdfe5e64756006ebdc0189
Cr-Commit-Position: refs/heads/master@{#438521}

Powered by Google App Engine
This is Rietveld 408576698