Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py

Issue 2573013002: Add inheritance support to Webmodules template. (Closed)
Patch Set: Whoops, forgot 'public'. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py
diff --git a/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py b/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py
index 28c81af28467810345bef3c3266c39028990b70a..6a0e23cf41aa25facb9c443814b47c16631711ea 100644
--- a/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py
+++ b/third_party/WebKit/Source/bindings/scripts/code_generator_web_module_test.py
@@ -11,6 +11,8 @@ import unittest
from code_generator_web_module import InterfaceContextBuilder
+# TODO(dglazkov): Convert to use actual objects, not stubs.
+# See http://crbug.com/673214 for more details.
class IdlTestingHelper(object):
"""A collection of stub makers and helper utils to make testing code
generation easy."""
@@ -52,6 +54,20 @@ class InterfaceContextBuilderTest(unittest.TestCase):
'class_name': 'foo',
}, builder.build())
+ def test_set_inheritance(self):
+ builder = InterfaceContextBuilder('test')
+ builder.set_inheritance('foo')
+ self.assertEqual({
+ 'code_generator': 'test',
+ 'inherits_expression': ' : public foo',
+ 'cpp_includes': set(['foo']),
+ }, builder.build())
+
+ builder = InterfaceContextBuilder('test')
+ builder.set_inheritance(None)
+ self.assertEqual({'code_generator': 'test'}, builder.build())
+
+
def test_add_attribute(self):
helper = IdlTestingHelper()
builder = InterfaceContextBuilder('test')

Powered by Google App Engine
This is Rietveld 408576698