Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2572953002: SELECT element: Do not update popup menu content by touching selectedIndex (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SELECT element: Do not update popup menu content by touching selectedIndex * HTMLSelectElement::selectOption Calls PopupMenu::updateFromElement() only if OPTION selection state was changed. BUG=673446 Committed: https://crrev.com/abc1c2f1d368e085dd3556f45c0fb861965abc75 Cr-Commit-Position: refs/heads/master@{#438461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 4 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
keishi@, would you review this please?
4 years ago (2016-12-14 02:16:26 UTC) #4
keishi
LGTM
4 years ago (2016-12-14 08:13:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572953002/1
4 years ago (2016-12-14 08:17:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 08:22:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 08:25:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abc1c2f1d368e085dd3556f45c0fb861965abc75
Cr-Commit-Position: refs/heads/master@{#438461}

Powered by Google App Engine
This is Rietveld 408576698