Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.h

Issue 2572953002: SELECT element: Do not update popup menu content by touching selectedIndex (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2000 Dirk Mueller (mueller@kde.org) 5 * (C) 2000 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights
7 * reserved. 7 * reserved.
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 228
229 bool hasPlaceholderLabelOption() const; 229 bool hasPlaceholderLabelOption() const;
230 230
231 enum SelectOptionFlag { 231 enum SelectOptionFlag {
232 DeselectOtherOptions = 1 << 0, 232 DeselectOtherOptions = 1 << 0,
233 DispatchInputAndChangeEvent = 1 << 1, 233 DispatchInputAndChangeEvent = 1 << 1,
234 MakeOptionDirty = 1 << 2, 234 MakeOptionDirty = 1 << 2,
235 }; 235 };
236 typedef unsigned SelectOptionFlags; 236 typedef unsigned SelectOptionFlags;
237 void selectOption(HTMLOptionElement*, SelectOptionFlags); 237 void selectOption(HTMLOptionElement*, SelectOptionFlags);
238 void deselectItemsWithoutValidation( 238 bool deselectItemsWithoutValidation(
239 HTMLOptionElement* elementToExclude = nullptr); 239 HTMLOptionElement* elementToExclude = nullptr);
240 void parseMultipleAttribute(const AtomicString&); 240 void parseMultipleAttribute(const AtomicString&);
241 HTMLOptionElement* lastSelectedOption() const; 241 HTMLOptionElement* lastSelectedOption() const;
242 void updateSelectedState(HTMLOptionElement*, bool multi, bool shift); 242 void updateSelectedState(HTMLOptionElement*, bool multi, bool shift);
243 void menuListDefaultEventHandler(Event*); 243 void menuListDefaultEventHandler(Event*);
244 void handlePopupOpenKeyboardEvent(Event*); 244 void handlePopupOpenKeyboardEvent(Event*);
245 bool shouldOpenPopupForKeyDownEvent(KeyboardEvent*); 245 bool shouldOpenPopupForKeyDownEvent(KeyboardEvent*);
246 bool shouldOpenPopupForKeyPressEvent(KeyboardEvent*); 246 bool shouldOpenPopupForKeyPressEvent(KeyboardEvent*);
247 void listBoxDefaultEventHandler(Event*); 247 void listBoxDefaultEventHandler(Event*);
248 void setOptionsChangedOnLayoutObject(); 248 void setOptionsChangedOnLayoutObject();
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 306
307 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption); 307 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, FirstSelectableOption);
308 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption); 308 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, LastSelectableOption);
309 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption); 309 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, NextSelectableOption);
310 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption); 310 FRIEND_TEST_ALL_PREFIXES(HTMLSelectElementTest, PreviousSelectableOption);
311 }; 311 };
312 312
313 } // namespace blink 313 } // namespace blink
314 314
315 #endif // HTMLSelectElement_h 315 #endif // HTMLSelectElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698