Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2572823002: Propogate the tab foreground, background change events to data use (Closed)

Created:
4 years ago by Raj
Modified:
4 years ago
Reviewers:
RyanSturm
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Propogate the tab foreground, background change events to data use This CL observes WebContents visibility changes to record if a data use entity (Chromium tab) is in foreground vs background. Further CLs will record the histograms. BUG=673820 Committed: https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7 Cr-Commit-Position: refs/heads/master@{#438922}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Addressed comments, added tests #

Patch Set 3 : Fix trybot failure #

Messages

Total messages: 23 (16 generated)
Raj
ptal
4 years ago (2016-12-13 18:43:57 UTC) #2
RyanSturm
Can you add some unit tests for this? https://codereview.chromium.org/2572823002/diff/1/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc File chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc (right): https://codereview.chromium.org/2572823002/diff/1/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc#newcode127 chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc:127: new_entry->set_is_visible(true); ...
4 years ago (2016-12-13 22:04:20 UTC) #3
Raj
Added unittests https://codereview.chromium.org/2572823002/diff/1/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc File chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc (right): https://codereview.chromium.org/2572823002/diff/1/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc#newcode127 chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc:127: new_entry->set_is_visible(true); On 2016/12/13 22:04:19, Ryan Sturm wrote: ...
4 years ago (2016-12-14 23:00:51 UTC) #5
RyanSturm
lgtm
4 years ago (2016-12-15 20:42:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572823002/60001
4 years ago (2016-12-15 20:54:55 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-15 21:04:56 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-15 21:08:28 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc0257d91a4a619fce84d274681f2bbc7f1c92b7
Cr-Commit-Position: refs/heads/master@{#438922}

Powered by Google App Engine
This is Rietveld 408576698