Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4759)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc

Issue 2572823002: Propogate the tab foreground, background change events to data use (Closed)
Patch Set: Fix trybot failure Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
index 966a1a9284cf461ae285b97b24dd38554a1122be..24e83c0f10ae84b3e7756f7298d5e4cde4dd5d4b 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
@@ -173,8 +173,50 @@ void ChromeDataUseAscriberService::SetDataUseAscriber(
for (auto& it : pending_frames_queue_) {
RenderFrameCreated(it);
+ if (pending_visible_main_frames_.find(it) !=
+ pending_visible_main_frames_.end()) {
+ WasShownOrHidden(it, true);
+ }
}
pending_frames_queue_.clear();
+ pending_visible_main_frames_.clear();
+}
+
+void ChromeDataUseAscriberService::WasShownOrHidden(
+ content::RenderFrameHost* main_render_frame_host,
+ bool visible) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+ if (!ascriber_) {
+ if (visible)
+ pending_visible_main_frames_.insert(main_render_frame_host);
+ else
+ pending_visible_main_frames_.erase(main_render_frame_host);
+ return;
+ }
+
+ content::BrowserThread::PostTask(
+ content::BrowserThread::IO, FROM_HERE,
+ base::Bind(&ChromeDataUseAscriber::WasShownOrHidden,
+ base::Unretained(ascriber_),
+ main_render_frame_host->GetProcess()->GetID(),
+ main_render_frame_host->GetRoutingID(), visible));
+}
+
+void ChromeDataUseAscriberService::RenderFrameHostChanged(
+ content::RenderFrameHost* old_host,
+ content::RenderFrameHost* new_host) {
+ if (!ascriber_)
+ return;
+
+ if (old_host) {
+ content::BrowserThread::PostTask(
+ content::BrowserThread::IO, FROM_HERE,
+ base::Bind(&ChromeDataUseAscriber::RenderFrameHostChanged,
+ base::Unretained(ascriber_), old_host->GetProcess()->GetID(),
+ old_host->GetRoutingID(), new_host->GetProcess()->GetID(),
+ new_host->GetRoutingID()));
+ }
}
} // namespace data_use_measurement

Powered by Google App Engine
This is Rietveld 408576698