Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2572813003: Form validation: Do not show validation bubble if the page is invisible. (Closed)

Created:
2 years, 5 months ago by tkent
Modified:
2 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Form validation: Do not show validation bubble if the page is invisible. BUG=673163 Committed: https://crrev.com/a8e17a3031b6ad69c399e5e04dd0084e577097fc Cr-Commit-Position: refs/heads/master@{#438476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
tkent
keishi@, would you review this please? I tried to make a layout test, but I ...
2 years, 5 months ago (2016-12-14 02:17:31 UTC) #4
keishi
LGTM
2 years, 5 months ago (2016-12-14 09:23:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572813003/1
2 years, 5 months ago (2016-12-14 09:51:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 5 months ago (2016-12-14 09:56:53 UTC) #12
commit-bot: I haz the power
2 years, 5 months ago (2016-12-14 09:59:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8e17a3031b6ad69c399e5e04dd0084e577097fc
Cr-Commit-Position: refs/heads/master@{#438476}

Powered by Google App Engine
This is Rietveld 408576698