Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2572813003: Form validation: Do not show validation bubble if the page is invisible. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 434 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 TextDirection& messageDir, 445 TextDirection& messageDir,
446 String& subMessage, 446 String& subMessage,
447 TextDirection& subMessageDir) { 447 TextDirection& subMessageDir) {
448 messageDir = determineDirectionality(message); 448 messageDir = determineDirectionality(message);
449 if (!subMessage.isEmpty()) 449 if (!subMessage.isEmpty())
450 subMessageDir = layoutObject()->style()->direction(); 450 subMessageDir = layoutObject()->style()->direction();
451 } 451 }
452 452
453 void HTMLFormControlElement::updateVisibleValidationMessage() { 453 void HTMLFormControlElement::updateVisibleValidationMessage() {
454 Page* page = document().page(); 454 Page* page = document().page();
455 if (!page) 455 if (!page || !page->isPageVisible())
456 return; 456 return;
457 String message; 457 String message;
458 if (layoutObject() && willValidate()) 458 if (layoutObject() && willValidate())
459 message = validationMessage().stripWhiteSpace(); 459 message = validationMessage().stripWhiteSpace();
460 460
461 m_hasValidationMessage = true; 461 m_hasValidationMessage = true;
462 ValidationMessageClient* client = &page->validationMessageClient(); 462 ValidationMessageClient* client = &page->validationMessageClient();
463 TextDirection messageDir = LTR; 463 TextDirection messageDir = LTR;
464 TextDirection subMessageDir = LTR; 464 TextDirection subMessageDir = LTR;
465 String subMessage = validationSubMessage().stripWhiteSpace(); 465 String subMessage = validationSubMessage().stripWhiteSpace();
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
625 const Element& source) { 625 const Element& source) {
626 HTMLElement::copyNonAttributePropertiesFromElement(source); 626 HTMLElement::copyNonAttributePropertiesFromElement(source);
627 setNeedsValidityCheck(); 627 setNeedsValidityCheck();
628 } 628 }
629 629
630 void HTMLFormControlElement::associateWith(HTMLFormElement* form) { 630 void HTMLFormControlElement::associateWith(HTMLFormElement* form) {
631 associateByParser(form); 631 associateByParser(form);
632 }; 632 };
633 633
634 } // namespace blink 634 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698