Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 2572783005: ImageHijackCanvas should skip non-lazy images from SkImageShader (Closed)

Created:
4 years ago by ericrk
Modified:
4 years ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ImageHijackCanvas should skip non-lazy images from SkImageShader ImageHijack canvas can currently hit a DCHECK when we try to process images from SkImageShaders, as it handles them even if they are non-lazy. Non-lazy images should be skipped. BUG=673981 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/d0cdd34fa6a729f4366e69b13a382c4f1943f3fd Cr-Commit-Position: refs/heads/master@{#438650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -2 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/image_hijack_canvas.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/playback/image_hijack_canvas.cc View 1 chunk +1 line, -1 line 0 comments Download
A cc/playback/image_hijack_canvas_unittest.cc View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ericrk
4 years ago (2016-12-14 19:18:49 UTC) #3
vmpstr
lgtm
4 years ago (2016-12-14 21:08:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572783005/1
4 years ago (2016-12-14 21:10:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 22:23:35 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-14 22:27:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0cdd34fa6a729f4366e69b13a382c4f1943f3fd
Cr-Commit-Position: refs/heads/master@{#438650}

Powered by Google App Engine
This is Rietveld 408576698