cc/playback/image_hijack_canvas.cc - Issue 2572783005: ImageHijackCanvas should skip non-lazy images from SkImageShader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/playback/image_hijack_canvas.cc

Issue 2572783005: ImageHijackCanvas should skip non-lazy images from SkImageShader (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/playback/image_hijack_canvas.cc

diff --git a/cc/playback/image_hijack_canvas.cc b/cc/playback/image_hijack_canvas.cc

index 98fd4717540037bab7af50cb391c706427c35fc5..a5d596d7e2f88a1eab3ba5b62cfcad2fe3cbcb26 100644

--- a/cc/playback/image_hijack_canvas.cc

+++ b/cc/playback/image_hijack_canvas.cc

@@ -83,7 +83,7 @@ class ScopedImagePaint {

SkMatrix matrix;

SkShader::TileMode xy[2];

SkImage* image = shader->isAImage(&matrix, xy);

- if (!image)

+ if (!image || !image->isLazyGenerated())

return base::Optional<ScopedImagePaint>();

SkMatrix total_image_matrix = matrix;

« no previous file with comments | « cc/playback/image_hijack_canvas.h ('k') | cc/playback/image_hijack_canvas_unittest.cc » ('j') | no next file with comments »