Revert of Collect active stylesheets and and apply asynchronously.

Revert of Collect active stylesheets and and apply asynchronously. (patchset #4 id:60001 of https://codereview.chromium.org/2557533005/ )

Reason for revert:
Suspected cause of failing WebKit tests on bots. Example: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6390

BUG=673850
Original issue's description:
> Collect active stylesheets and and apply asynchronously.
>
> This CL enables asynchronously updating the lists of active stylesheets
> applying any style changes using rule set invalidations. This means we
> more often avoid full style recalcs when we add or remove stylesheets
> from the document as well as when the evaluation of media queries
> change.
>
> In general, we now alway compare new and old stylesheets by comparing
> their rulesets and schedule style invalidations for removed and added
> rulesets.
>
> When media queries changes, we used to give completely in and
> recalculate all style once we discovered a media query changed its
> evaluation. With this patch, we clear rule sets for sheets which
> contain media queries which means we will invalidate rules for the sets
> before and after the query change. This can be further refined by only
> clearing rule sets when the sheets has a media query which actually did
> change evaluation, and also just schedule invalidations for rules which
> are inside @media rules.
>
> TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
> ActiveStyleSheetsTest.cpp which landed earlier.
>
> updateActiveStyle() has been added a few places where
> ensureStyleResolver() previously caused active stylesheets to be up-to-
> date. ensureStyleResolver() is now merely a method which creates the
> StyleResolver if necessary and returns it.
>
> There are some cleanups and code removal which needs to be done after
> this CL, but I have left those out to make this CL as small as
> possible. For instance resolverChanged(), which synchronously updated
> the active stylesheets, has an empty implementation instead of
> including a lot of removals in this CL. The code for lazy-appending
> stylesheets in StyleResolver is still there, but not in use.
>
> R=meade@chromium.org
> BUG=567021
>
> Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
> Cr-Commit-Position: refs/heads/master@{#438148}

TBR=esprehn@chromium.org,meade@chromium.org,sashab@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567021
Committed: https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147
Cr-Commit-Position: refs/heads/master@{#438278}

[paulmeyer, 2016-12-13 20:52:31]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2016-12-13 20:52:31]

Created Revert of Collect active stylesheets and and apply asynchronously.

[commit-bot: I haz the power, 2016-12-13 20:53:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 20:54:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481662351535900, "parent_rev":
"cd7a757c8bbfaf76cf7306e63a712d2eb84ed016", "commit_rev":
"f62de52ee32db074173945c99f24158f50b662b4"}

[commit-bot: I haz the power, 2016-12-13 20:55:22]

Description was changed from

==========
Revert of Collect active stylesheets and and apply asynchronously. (patchset #4
id:60001 of https://codereview.chromium.org/2557533005/ )

Reason for revert:
Suspected cause of failing WebKit tests on bots. Example:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...

BUG=673850

Original issue's description:
> Collect active stylesheets and and apply asynchronously.
> 
> This CL enables asynchronously updating the lists of active stylesheets
> applying any style changes using rule set invalidations. This means we
> more often avoid full style recalcs when we add or remove stylesheets
> from the document as well as when the evaluation of media queries
> change.
> 
> In general, we now alway compare new and old stylesheets by comparing
> their rulesets and schedule style invalidations for removed and added
> rulesets.
> 
> When media queries changes, we used to give completely in and
> recalculate all style once we discovered a media query changed its
> evaluation. With this patch, we clear rule sets for sheets which
> contain media queries which means we will invalidate rules for the sets
> before and after the query change. This can be further refined by only
> clearing rule sets when the sheets has a media query which actually did
> change evaluation, and also just schedule invalidations for rules which
> are inside @media rules.
> 
> TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
> ActiveStyleSheetsTest.cpp which landed earlier.
> 
> updateActiveStyle() has been added a few places where
> ensureStyleResolver() previously caused active stylesheets to be up-to-
> date. ensureStyleResolver() is now merely a method which creates the
> StyleResolver if necessary and returns it.
> 
> There are some cleanups and code removal which needs to be done after
> this CL, but I have left those out to make this CL as small as
> possible. For instance resolverChanged(), which synchronously updated
> the active stylesheets, has an empty implementation instead of
> including a lot of removals in this CL. The code for lazy-appending
> stylesheets in StyleResolver is still there, but not in use.
> 
> R=meade@chromium.org
> BUG=567021
> 
> Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
> Cr-Commit-Position: refs/heads/master@{#438148}

TBR=esprehn@chromium.org,meade@chromium.org,sashab@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567021
==========

to

==========
Revert of Collect active stylesheets and and apply asynchronously. (patchset #4
id:60001 of https://codereview.chromium.org/2557533005/ )

Reason for revert:
Suspected cause of failing WebKit tests on bots. Example:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...

BUG=673850

Original issue's description:
> Collect active stylesheets and and apply asynchronously.
> 
> This CL enables asynchronously updating the lists of active stylesheets
> applying any style changes using rule set invalidations. This means we
> more often avoid full style recalcs when we add or remove stylesheets
> from the document as well as when the evaluation of media queries
> change.
> 
> In general, we now alway compare new and old stylesheets by comparing
> their rulesets and schedule style invalidations for removed and added
> rulesets.
> 
> When media queries changes, we used to give completely in and
> recalculate all style once we discovered a media query changed its
> evaluation. With this patch, we clear rule sets for sheets which
> contain media queries which means we will invalidate rules for the sets
> before and after the query change. This can be further refined by only
> clearing rule sets when the sheets has a media query which actually did
> change evaluation, and also just schedule invalidations for rules which
> are inside @media rules.
> 
> TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
> ActiveStyleSheetsTest.cpp which landed earlier.
> 
> updateActiveStyle() has been added a few places where
> ensureStyleResolver() previously caused active stylesheets to be up-to-
> date. ensureStyleResolver() is now merely a method which creates the
> StyleResolver if necessary and returns it.
> 
> There are some cleanups and code removal which needs to be done after
> this CL, but I have left those out to make this CL as small as
> possible. For instance resolverChanged(), which synchronously updated
> the active stylesheets, has an empty implementation instead of
> including a lot of removals in this CL. The code for lazy-appending
> stylesheets in StyleResolver is still there, but not in use.
> 
> R=meade@chromium.org
> BUG=567021
> 
> Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
> Cr-Commit-Position: refs/heads/master@{#438148}

TBR=esprehn@chromium.org,meade@chromium.org,sashab@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567021

Review-Url: https://codereview.chromium.org/2572473006
==========

[commit-bot: I haz the power, 2016-12-13 20:55:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 20:57:22]

Description was changed from

==========
Revert of Collect active stylesheets and and apply asynchronously. (patchset #4
id:60001 of https://codereview.chromium.org/2557533005/ )

Reason for revert:
Suspected cause of failing WebKit tests on bots. Example:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...

BUG=673850

Original issue's description:
> Collect active stylesheets and and apply asynchronously.
> 
> This CL enables asynchronously updating the lists of active stylesheets
> applying any style changes using rule set invalidations. This means we
> more often avoid full style recalcs when we add or remove stylesheets
> from the document as well as when the evaluation of media queries
> change.
> 
> In general, we now alway compare new and old stylesheets by comparing
> their rulesets and schedule style invalidations for removed and added
> rulesets.
> 
> When media queries changes, we used to give completely in and
> recalculate all style once we discovered a media query changed its
> evaluation. With this patch, we clear rule sets for sheets which
> contain media queries which means we will invalidate rules for the sets
> before and after the query change. This can be further refined by only
> clearing rule sets when the sheets has a media query which actually did
> change evaluation, and also just schedule invalidations for rules which
> are inside @media rules.
> 
> TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
> ActiveStyleSheetsTest.cpp which landed earlier.
> 
> updateActiveStyle() has been added a few places where
> ensureStyleResolver() previously caused active stylesheets to be up-to-
> date. ensureStyleResolver() is now merely a method which creates the
> StyleResolver if necessary and returns it.
> 
> There are some cleanups and code removal which needs to be done after
> this CL, but I have left those out to make this CL as small as
> possible. For instance resolverChanged(), which synchronously updated
> the active stylesheets, has an empty implementation instead of
> including a lot of removals in this CL. The code for lazy-appending
> stylesheets in StyleResolver is still there, but not in use.
> 
> R=meade@chromium.org
> BUG=567021
> 
> Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
> Cr-Commit-Position: refs/heads/master@{#438148}

TBR=esprehn@chromium.org,meade@chromium.org,sashab@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567021

Review-Url: https://codereview.chromium.org/2572473006
==========

to

==========
Revert of Collect active stylesheets and and apply asynchronously. (patchset #4
id:60001 of https://codereview.chromium.org/2557533005/ )

Reason for revert:
Suspected cause of failing WebKit tests on bots. Example:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac1...

BUG=673850

Original issue's description:
> Collect active stylesheets and and apply asynchronously.
>
> This CL enables asynchronously updating the lists of active stylesheets
> applying any style changes using rule set invalidations. This means we
> more often avoid full style recalcs when we add or remove stylesheets
> from the document as well as when the evaluation of media queries
> change.
>
> In general, we now alway compare new and old stylesheets by comparing
> their rulesets and schedule style invalidations for removed and added
> rulesets.
>
> When media queries changes, we used to give completely in and
> recalculate all style once we discovered a media query changed its
> evaluation. With this patch, we clear rule sets for sheets which
> contain media queries which means we will invalidate rules for the sets
> before and after the query change. This can be further refined by only
> clearing rule sets when the sheets has a media query which actually did
> change evaluation, and also just schedule invalidations for rules which
> are inside @media rules.
>
> TreeScopeStyleSheetCollectionTest.cpp is removed as it is replaced by
> ActiveStyleSheetsTest.cpp which landed earlier.
>
> updateActiveStyle() has been added a few places where
> ensureStyleResolver() previously caused active stylesheets to be up-to-
> date. ensureStyleResolver() is now merely a method which creates the
> StyleResolver if necessary and returns it.
>
> There are some cleanups and code removal which needs to be done after
> this CL, but I have left those out to make this CL as small as
> possible. For instance resolverChanged(), which synchronously updated
> the active stylesheets, has an empty implementation instead of
> including a lot of removals in this CL. The code for lazy-appending
> stylesheets in StyleResolver is still there, but not in use.
>
> R=meade@chromium.org
> BUG=567021
>
> Committed: https://crrev.com/9fb5b60edfb769134733009f9447bad3eaf347b0
> Cr-Commit-Position: refs/heads/master@{#438148}

TBR=esprehn@chromium.org,meade@chromium.org,sashab@chromium.org,rune@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567021

Committed: https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147
Cr-Commit-Position: refs/heads/master@{#438278}
==========

[commit-bot: I haz the power, 2016-12-13 20:57:23]

Patchset 1 (id:??) landed as
https://crrev.com/14e73349c627e9e861263bd069d63ac7df9c3147
Cr-Commit-Position: refs/heads/master@{#438278}

[esprehn, 2016-12-13 21:02:02]

Is there a public builder link? The contributor is external to Google, they
can't see the .corp.google.com links.

[esprehn, 2016-12-13 21:04:08]

On 2016/12/13 at 21:02:02, esprehn wrote:
> Is there a public builder link? The contributor is external to Google, they
can't see the .corp.google.com links.

rune@ FYI:

webkit_tests webkit_tests

unexpected_failures:
virtual/mojo-loading/http/tests/webfont/font-display.html
http/tests/webfont/font-display.html
virtual/mojo-loading/http/tests/webfont/font-display-intervention.html
http/tests/webfont/font-display-intervention.html

Total executed: 47002

[rune, 2016-12-13 21:45:44]

On 2016/12/13 21:04:08, esprehn wrote:
> On 2016/12/13 at 21:02:02, esprehn wrote:
> > Is there a public builder link? The contributor is external to Google, they
> can't see the .corp.google.com links.
> 
> rune@ FYI:
> 
> webkit_tests webkit_tests
> 
> unexpected_failures:
> virtual/mojo-loading/http/tests/webfont/font-display.html
> http/tests/webfont/font-display.html
> virtual/mojo-loading/http/tests/webfont/font-display-intervention.html
> http/tests/webfont/font-display-intervention.html
> 
> Total executed: 47002

Thanks. Luckily I have a MacBook with this patch compiled readily available here
and it turns out both tests fail with --debug and not in release.