third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html - Issue 2572473006: Revert of Collect active stylesheets and and apply asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

Issue 2572473006: Revert of Collect active stylesheets and and apply asynchronously. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/add-keyframes-in-shadow-recalc.html ('k') | third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html b/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

index f8b755fb0ade60afa9997f3fb217d1dc227faddf..40814c59175bf4f780e1183fbe7436752fbac9a4 100644

--- a/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

+++ b/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

@@ -56,7 +56,8 @@

// Test deleteRule

forceRecalc();

sheet.sheet.deleteRule(0); // Deletes .bar rule.

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "6");

+ // FIXME: Ideally we'd do StyleInvalidationAnalysis here and only recalc 3 bar's, 3 baz's + documentElement

+ shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "43");

shouldBe("getComputedStyle(document.querySelector('.foo')).color", '"rgb(0, 0, 0)"');

shouldBe("getComputedStyle(document.querySelector('.baz')).color", '"rgb(255, 0, 0)"');

@@ -65,7 +66,8 @@

// Test insertRule

forceRecalc();

sheet.sheet.insertRule(".foo { color: red; }", 0);

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "6");

+ // FIXME: Ideally we'd do StyleInvalidationAnalysis here and only recalc 3 foo's, 3 baz's + documentElement

+ shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "59");

shouldBe("getComputedStyle(document.querySelector('.foo')).color", '"rgb(255, 0, 0)"');

shouldBe("getComputedStyle(document.querySelector('.baz')).color", '"rgb(255, 0, 0)"');