third_party/WebKit/Source/modules/presentation/PresentationError.cpp - Issue 2572473003: [Presentation API] PresentationRequest::getAvailability() should return the same promise

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationError.cpp

Issue 2572473003: [Presentation API] PresentationRequest::getAvailability() should return the same promise (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/presentation/PresentationAvailability.h ('K') | « third_party/WebKit/Source/modules/presentation/PresentationError.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequest.h » ('j') | third_party/WebKit/Source/modules/presentation/PresentationRequest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationError.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationError.cpp b/third_party/WebKit/Source/modules/presentation/PresentationError.cpp

index c40380bc0ea2cc77417089ebf109a1c6c4d26001..f238e043fc4c53f71c11317c0d5415f81d2fec48 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationError.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationError.cpp

@@ -11,8 +11,7 @@

namespace blink {

// static

-DOMException* PresentationError::take(ScriptPromiseResolver*,

- const WebPresentationError& error) {

+DOMException* PresentationError::take(const WebPresentationError& error) {

mlamouri (slow - plz ping) 2016/12/13 13:56:12 For next time, in the spirit of keeping the CLs at

zhaobin 2016/12/14 02:25:09 Sure :)

ExceptionCode code = UnknownError;

switch (error.errorType) {

case WebPresentationError::ErrorTypeNoAvailableScreens: