Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationRequest.h

Issue 2572473003: [Presentation API] PresentationRequest::getAvailability() should return the same promise (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationRequest.h
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationRequest.h b/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
index 70cd618b38c7cb291353e6c0a77bfb31ca8ba5ec..ed118037ba412731bd5af7b68ad9fe22ad7a4c2e 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
+++ b/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
@@ -7,19 +7,31 @@
#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "bindings/core/v8/ScriptPromise.h"
+#include "bindings/core/v8/ScriptPromiseProperty.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
+#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
#include "platform/heap/Heap.h"
#include "platform/weborigin/KURL.h"
namespace blink {
+class DOMException;
+class PresentationAvailability;
+class PresentationRequest;
+
+using PresentationAvailabilityProperty =
+ ScriptPromiseProperty<Member<PresentationRequest>,
+ Member<PresentationAvailability>,
+ Member<DOMException>>;
+
// Implements the PresentationRequest interface from the Presentation API from
// which websites can start or join presentation connections.
-class PresentationRequest final : public EventTargetWithInlineData,
- public ActiveScriptWrappable,
- public ActiveDOMObject {
+class MODULES_EXPORT PresentationRequest final
mlamouri (slow - plz ping) 2016/12/13 13:56:12 Why did this become MODULES_EXPORT?
zhaobin 2016/12/14 02:25:09 Needed in unit tests.
+ : public EventTargetWithInlineData,
+ public ActiveScriptWrappable,
+ public ActiveDOMObject {
USING_GARBAGE_COLLECTED_MIXIN(PresentationRequest);
DEFINE_WRAPPERTYPEINFO();
@@ -55,6 +67,7 @@ class PresentationRequest final : public EventTargetWithInlineData,
private:
PresentationRequest(ExecutionContext*, const KURL&);
+ Member<PresentationAvailabilityProperty> m_availabilityProperty;
KURL m_url;
};

Powered by Google App Engine
This is Rietveld 408576698