third_party/WebKit/Source/modules/presentation/PresentationAvailability.h - Issue 2572473003: [Presentation API] PresentationRequest::getAvailability() should return the same promise

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationAvailability.h

Issue 2572473003: [Presentation API] PresentationRequest::getAvailability() should return the same promise (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp » ('j') | third_party/WebKit/Source/modules/presentation/PresentationError.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationAvailability.h

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h b/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h

index 12ad7d94d24b01a5700117e329aee8b58bfe957a..25517f0bdda7e0250381239b62dbcfe7a414d6a8 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h

+++ b/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h

@@ -10,6 +10,7 @@

#include "core/events/EventTarget.h"

#include "core/page/PageVisibilityObserver.h"

#include "modules/ModulesExport.h"

+#include "modules/presentation/PresentationRequest.h"

#include "platform/weborigin/KURL.h"

#include "public/platform/WebURL.h"

#include "public/platform/modules/presentation/WebPresentationAvailabilityObserver.h"

@@ -17,7 +18,6 @@

namespace blink {

class ExecutionContext;

-class ScriptPromiseResolver;

// Expose whether there is a presentation display available for |url|. The

// object will be initialized with a default value passed via ::take() and will

@@ -33,7 +33,7 @@ class MODULES_EXPORT PresentationAvailability final

DEFINE_WRAPPERTYPEINFO();

public:

- static PresentationAvailability* take(ScriptPromiseResolver*,

+ static PresentationAvailability* take(PresentationAvailabilityProperty*,

mlamouri (slow - plz ping) 2016/12/13 13:56:12 Can you forward declare one way or another?

zhaobin 2016/12/14 02:25:09 Cannot forward declare using. Create a seperate .h

mlamouri (slow - plz ping) 2016/12/14 12:25:06 An alternative would be to simply re-declare the t

zhaobin 2016/12/14 20:51:53 Yes, it works. It concerns me a little because we

const KURL&,

bool);

~PresentationAvailability() override;