Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp

Issue 2572473003: [Presentation API] PresentationRequest::getAvailability() should return the same promise (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp b/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
index 6484e39f669d1e90fbcd4887403c8e908cde9561..888ff33c472f57338ed6b49b8e558044ff95650d 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityTest.cpp
@@ -6,9 +6,11 @@
#include "bindings/core/v8/ScriptPromiseResolver.h"
#include "bindings/core/v8/V8BindingForTesting.h"
+#include "core/dom/DOMException.h"
#include "core/frame/LocalFrame.h"
#include "core/page/Page.h"
#include "core/testing/DummyPageHolder.h"
+#include "modules/presentation/PresentationRequest.h"
#include "platform/testing/URLTestHelpers.h"
#include "platform/weborigin/KURL.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -20,8 +22,10 @@ namespace {
TEST(PresentationAvailabilityTest, NoPageVisibilityChangeAfterDetach) {
V8TestingScope scope;
const KURL url = URLTestHelpers::toKURL("https://example.com");
- Persistent<ScriptPromiseResolver> resolver =
- ScriptPromiseResolver::create(scope.getScriptState());
+ Persistent<PresentationAvailabilityProperty> resolver =
+ new PresentationAvailabilityProperty(
+ scope.getExecutionContext(), nullptr,
+ PresentationAvailabilityProperty::Ready);
Persistent<PresentationAvailability> availability =
PresentationAvailability::take(resolver, url, false);

Powered by Google App Engine
This is Rietveld 408576698