[Presentation API] PresentationRequest::getAvailability() should return the same promise

third_party/WebKit/Source/modules/presentation/PresentationAvailability.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PresentationAvailability_h
 #define PresentationAvailability_h
 
 #include "bindings/core/v8/ActiveScriptWrappable.h"
 #include "core/dom/ActiveDOMObject.h"
 #include "core/events/EventTarget.h"
 #include "core/page/PageVisibilityObserver.h"
 #include "modules/ModulesExport.h"
+#include "modules/presentation/PresentationRequest.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/WebURL.h"
 #include "public/platform/modules/presentation/WebPresentationAvailabilityObserver.h"
 
 namespace blink {
 
 class ExecutionContext;
-class ScriptPromiseResolver;
 
 // Expose whether there is a presentation display available for |url|. The
 // object will be initialized with a default value passed via ::take() and will
 // then subscribe to receive callbacks if the status for |url| were to
 // change. The object will only listen to changes when required.
 class MODULES_EXPORT PresentationAvailability final
     : public EventTargetWithInlineData,
       public ActiveScriptWrappable,
       public ActiveDOMObject,
       public PageVisibilityObserver,
       public WebPresentationAvailabilityObserver {
   USING_GARBAGE_COLLECTED_MIXIN(PresentationAvailability);
   DEFINE_WRAPPERTYPEINFO();
 
  public:
-  static PresentationAvailability* take(ScriptPromiseResolver*,
+  static PresentationAvailability* take(PresentationAvailabilityProperty*,

[mlamouri (slow - plz ping), 2016/12/13 13:56:12]

Can you forward declare one way or another?

[zhaobin, 2016/12/14 02:25:09]

Cannot forward declare using. Create a seperate .h file for this...

[mlamouri (slow - plz ping), 2016/12/14 12:25:06]

An alternative would be to simply re-declare the template name in this header,
wouldn't it work?

[zhaobin, 2016/12/14 20:51:53]

Yes, it works. It concerns me a little because we need to declear the same using
in PresentationRequest.h, PresentationAvailability.h and
PresentationAvailabilityCallbacks.h. Would creating a .h file better in this
case?

                                         const KURL&,
                                         bool);
   ~PresentationAvailability() override;
 
   // EventTarget implementation.
   const AtomicString& interfaceName() const override;
   ExecutionContext* getExecutionContext() const override;
 
   // WebPresentationAvailabilityObserver implementation.
   void availabilityChanged(bool) override;
@@ skipping 38 matching lines @@
   void updateListening();
 
   const KURL m_url;
   bool m_value;
   State m_state;
 };
 
 }  // namespace blink
 
 #endif  // PresentationAvailability_h