Loading: pass minimum information to Resource::resourceTypeToString()

Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920
Committed: https://crrev.com/13f041896a0a9a9bbca893f9f4fb62ce4b500827
Cr-Commit-Position: refs/heads/master@{#439442}

[Takashi Toyoshima, 2016-12-15 11:06:14]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 11:06:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Takashi Toyoshima, 2016-12-15 11:06:55]

Description was changed from

==========
Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920
==========

to

==========
Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920
==========

[Takashi Toyoshima, 2016-12-15 11:06:56]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[Takashi Toyoshima, 2016-12-15 11:07:09]

ptal

[commit-bot: I haz the power, 2016-12-15 14:08:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:08:41]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2016-12-15 14:53:54]

yoav@yoav.ws changed reviewers:
+ yoav@yoav.ws

[Yoav Weiss, 2016-12-15 14:53:55]

LGTM

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:57: #include <type_traits>
Why is this header needed?

[Takashi Toyoshima, 2016-12-19 05:47:48]

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:57: #include <type_traits>
Oh, I mistakenly use this but the right header for static_assert() seems to be
<cassert>.

[yhirano, 2016-12-19 06:23:08]

lgtm

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:1031: static const char*
initatorTypeNameToString(
Not related to this change but this name should be initiatorTypeNameToString.

[Takashi Toyoshima, 2016-12-19 06:59:01]

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2572373003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:1031: static const char*
initatorTypeNameToString(
On 2016/12/19 06:23:08, yhirano wrote:
> Not related to this change but this name should be initiatorTypeNameToString.

Done.

[Takashi Toyoshima, 2016-12-19 06:59:29]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-12-19 06:59:29]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2572373003/#ps20001
(title: "review #9 #11")

[commit-bot: I haz the power, 2016-12-19 06:59:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 09:26:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482130769600050,
"parent_rev": "4d0a364aa5901549691098920e1e3c8dfe9154bf", "commit_rev":
"0b300da4ba11abaa522cf143d0ce9da23a2ed5f0"}

[commit-bot: I haz the power, 2016-12-19 09:26:31]

Description was changed from

==========
Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920
==========

to

==========
Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920

Review-Url: https://codereview.chromium.org/2572373003
==========

[commit-bot: I haz the power, 2016-12-19 09:26:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-19 09:28:41]

Description was changed from

==========
Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920

Review-Url: https://codereview.chromium.org/2572373003
==========

to

==========
Loading: pass minimum information to Resource::resourceTypeToString()

Now Resource::resourceTypeToString() takes const FetchInitiatorInfo&,
but just uses FetchInitiatorInfo.name.

This patch changes the interface to only take const AtomicString& of
FetchInitiatorInfo.name to have minimum dependencies each other.

Also add a static_assert() for FetchInitiatorTypeNames because code
looks easily broken when someone want to add a new type.

This is a preparation to remove binding/core dependency from core/fetch.

BUG=655920

Committed: https://crrev.com/13f041896a0a9a9bbca893f9f4fb62ce4b500827
Cr-Commit-Position: refs/heads/master@{#439442}
==========

[commit-bot: I haz the power, 2016-12-19 09:28:42]

Patchset 2 (id:??) landed as
https://crrev.com/13f041896a0a9a9bbca893f9f4fb62ce4b500827
Cr-Commit-Position: refs/heads/master@{#439442}