Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2578983002: Loading: move V8DOMActivityLogger dependency from core/fetch (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
Reviewers:
yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Loading: move V8DOMActivityLogger dependency from core/fetch Now, core/fetch has a dependency to bindings/core/, but this won't be permitted once the directory is moved to platform/loader/fetch. This patch moves this last unexpected dependency, and make it finally possible to move under platform/. BUG=655920 Committed: https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77 Cr-Commit-Position: refs/heads/master@{#439806}

Patch Set 1 #

Total comments: 4

Patch Set 2 : merge 2572373003/#ps20001 #

Total comments: 2

Patch Set 3 : review #9 #

Patch Set 4 : merge master #

Patch Set 5 : update comments to refer crbug #

Patch Set 6 : DEPS update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -31 lines) Patch
M third_party/WebKit/Source/core/fetch/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.h View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchContext.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/FetchRequest.h View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 2 3 2 chunks +2 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 2 3 4 chunks +27 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-19 05:48:12 UTC) #8
yhirano
https://codereview.chromium.org/2578983002/diff/1/third_party/WebKit/Source/core/fetch/FetchContext.h File third_party/WebKit/Source/core/fetch/FetchContext.h (right): https://codereview.chromium.org/2578983002/diff/1/third_party/WebKit/Source/core/fetch/FetchContext.h#newcode44 third_party/WebKit/Source/core/fetch/FetchContext.h:44: namespace wtf { wtf/Forward.h https://codereview.chromium.org/2578983002/diff/1/third_party/WebKit/Source/core/loader/FrameFetchContext.h File third_party/WebKit/Source/core/loader/FrameFetchContext.h (right): https://codereview.chromium.org/2578983002/diff/1/third_party/WebKit/Source/core/loader/FrameFetchContext.h#newcode42 ...
4 years ago (2016-12-19 11:44:47 UTC) #9
Takashi Toyoshima
https://codereview.chromium.org/2578983002/diff/1/third_party/WebKit/Source/core/fetch/FetchContext.h File third_party/WebKit/Source/core/fetch/FetchContext.h (right): https://codereview.chromium.org/2578983002/diff/1/third_party/WebKit/Source/core/fetch/FetchContext.h#newcode44 third_party/WebKit/Source/core/fetch/FetchContext.h:44: namespace wtf { On 2016/12/19 11:44:46, yhirano wrote: > ...
4 years ago (2016-12-19 12:58:54 UTC) #10
yhirano
lgtm It might be good to add an entry in core/fetch/DEPS to forbid dependency to ...
4 years ago (2016-12-20 12:14:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2578983002/100001
4 years ago (2016-12-20 13:54:24 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-12-20 15:18:57 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-20 15:20:38 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5daea93d2ae560a310f341015ec9d21b0fcfea77
Cr-Commit-Position: refs/heads/master@{#439806}

Powered by Google App Engine
This is Rietveld 408576698