Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2572363002: Revert of Fixed dragging a folder from bookmark manager to open all elements in new tabs (Closed)

Created:
4 years ago by erikchen
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org, Mark P
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixed dragging a folder from bookmark manager to open all elements in new tabs (patchset #7 id:120001 of https://codereview.chromium.org/2502483002/ ) Reason for revert: Reverting because this introduces a bug: https://bugs.chromium.org/p/chromium/issues/detail?id=672805 Original issue's description: > Fixed dragging a folder from bookmark manager to open all elements in new tabs > > Dropping a bookmark folder on Omnibox or Tab strip will open all of the urls in > separate tabs. > > Note that this does not include urls within nested folders, because > BookmarkNodeData.WriteToClipboard (bookmark_node_data.cc:190) does not put urls > from nested folders into clipboard. > > I have two questions from reviewers: > > 1) Do we have to record metrics in ToolbarController like what we have in > TabStripController.OpenUrl()? > > 2) I could not find any unit test for testing DropUrls of tab_strip_controller.mm > and toolbar_controller.mm, am I right? > > BUG=661765 > > Committed: https://crrev.com/d2e643efc4cceed77e046658a588f1559f1b1e88 > Cr-Commit-Position: refs/heads/master@{#434124} TBR=avi@chromium.org,shrike@chromium.org,shahriar.rostami@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=661765 Committed: https://crrev.com/8caa17af5b4d349cb2a0df07b2b79824d89591db Cr-Commit-Position: refs/heads/master@{#438851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -62 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 8 chunks +24 lines, -43 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +18 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
erikchen
Created Revert of Fixed dragging a folder from bookmark manager to open all elements in ...
4 years ago (2016-12-15 01:46:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572363002/1
4 years ago (2016-12-15 01:46:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/335019) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
4 years ago (2016-12-15 01:51:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572363002/1
4 years ago (2016-12-15 16:47:56 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-15 16:59:39 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-15 17:02:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8caa17af5b4d349cb2a0df07b2b79824d89591db
Cr-Commit-Position: refs/heads/master@{#438851}

Powered by Google App Engine
This is Rietveld 408576698