DescriptionRevert of Fixed dragging a folder from bookmark manager to open all elements in new tabs (patchset #7 id:120001 of https://codereview.chromium.org/2502483002/ )
Reason for revert:
Reverting because this introduces a bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=672805
Original issue's description:
> Fixed dragging a folder from bookmark manager to open all elements in new tabs
>
> Dropping a bookmark folder on Omnibox or Tab strip will open all of the urls in
> separate tabs.
>
> Note that this does not include urls within nested folders, because
> BookmarkNodeData.WriteToClipboard (bookmark_node_data.cc:190) does not put urls
> from nested folders into clipboard.
>
> I have two questions from reviewers:
>
> 1) Do we have to record metrics in ToolbarController like what we have in
> TabStripController.OpenUrl()?
>
> 2) I could not find any unit test for testing DropUrls of tab_strip_controller.mm
> and toolbar_controller.mm, am I right?
>
> BUG=661765
>
> Committed: https://crrev.com/d2e643efc4cceed77e046658a588f1559f1b1e88
> Cr-Commit-Position: refs/heads/master@{#434124}
TBR=avi@chromium.org,shrike@chromium.org,shahriar.rostami@gmail.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=661765
Committed: https://crrev.com/8caa17af5b4d349cb2a0df07b2b79824d89591db
Cr-Commit-Position: refs/heads/master@{#438851}
Patch Set 1 #
Messages
Total messages: 12 (6 generated)
|