Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2572113002: Condition SecKeyAlgorithm (re)declaration on min, not max version. (Closed)

Created:
4 years ago by davidben
Modified:
4 years ago
Reviewers:
erikchen
CC:
chromium-reviews, cbentzel+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Condition SecKeyAlgorithm (re)declaration on min, not max version. We not only need to declare it prior to the 10.12 SDK due to the typedef being missing but, because of -Wpartial-availability, we need to redeclare it even on the 10.12 SDK until the minimum version is 10.12 or later. BUG=none Committed: https://crrev.com/d16880639bed5b1ce61aa78e11ec3530b5a7e815 Cr-Commit-Position: refs/heads/master@{#438577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M net/ssl/ssl_platform_key_mac.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
davidben
Does this look right? See https://codereview.chromium.org/2566273008/#msg20
4 years ago (2016-12-14 13:06:08 UTC) #4
erikchen
lgtm
4 years ago (2016-12-14 18:54:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572113002/1
4 years ago (2016-12-14 19:09:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-14 19:16:20 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-14 19:19:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d16880639bed5b1ce61aa78e11ec3530b5a7e815
Cr-Commit-Position: refs/heads/master@{#438577}

Powered by Google App Engine
This is Rietveld 408576698