Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/ssl/ssl_platform_key_mac.cc

Issue 2572113002: Condition SecKeyAlgorithm (re)declaration on min, not max version. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_platform_key_mac.cc
diff --git a/net/ssl/ssl_platform_key_mac.cc b/net/ssl/ssl_platform_key_mac.cc
index 1e0d81fd333342d6b0488e15f4bca25a2ea9a21e..373f4323e0709c571a40501e1fc8207ea6444cc8 100644
--- a/net/ssl/ssl_platform_key_mac.cc
+++ b/net/ssl/ssl_platform_key_mac.cc
@@ -39,9 +39,10 @@
#include "third_party/boringssl/src/include/openssl/nid.h"
#include "third_party/boringssl/src/include/openssl/rsa.h"
-// TODO(davidben): Remove this after https://crbug.com/669240 is fixed.
#if !defined(MAC_OS_X_VERSION_10_12) || \
- MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_12
+ MAC_OS_X_VERSION_MIN_ALLOWED < MAC_OS_X_VERSION_10_12
+// Redeclare typedefs that only exist in 10.12+ to suppress
+// -Wpartial-availability warnings.
typedef CFStringRef SecKeyAlgorithm;
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698