Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2572063002: FasterLocationReload: Add a field trial flag to enable the feature (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FasterLocationReload: Add a field trial flag to enable the feature The feature is planned to be enabled step by step through a server side configuration. This patch add a field trial flag and plumb it to the Blink runtime flag to enable it. BUG=670237 Committed: https://crrev.com/ccf646e53afed85c5d06b501548f7c1520452d0d Cr-Commit-Position: refs/heads/master@{#439434}

Patch Set 1 #

Patch Set 2 : one more group for histograms #

Patch Set 3 : merge master #

Patch Set 4 : merge master again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (21 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-15 06:37:09 UTC) #12
jochen (gone - plz use gerrit)
is there a particular reason this needs an about:flags entry? lgtm on the code changes. ...
4 years ago (2016-12-15 14:20:01 UTC) #16
Ilya Sherman
histograms.xml lgtm
4 years ago (2016-12-15 23:08:01 UTC) #17
Takashi Toyoshima
jochen: Yes, this feature is planned to be enabled over the field study infra step ...
4 years ago (2016-12-19 05:55:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572063002/40001
4 years ago (2016-12-19 05:56:16 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/88551)
4 years ago (2016-12-19 06:23:13 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2572063002/60001
4 years ago (2016-12-19 07:10:45 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-19 08:36:22 UTC) #28
commit-bot: I haz the power
4 years ago (2016-12-19 08:38:57 UTC) #30
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ccf646e53afed85c5d06b501548f7c1520452d0d
Cr-Commit-Position: refs/heads/master@{#439434}

Powered by Google App Engine
This is Rietveld 408576698