Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2572063002: FasterLocationReload: Add a field trial flag to enable the feature (Closed)
Patch Set: merge master again Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/child/runtime_features.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2115 matching lines...) Expand 10 before | Expand all | Expand 10 after
2126 {"enable-nostate-prefetch", IDS_FLAGS_NOSTATE_PREFETCH, 2126 {"enable-nostate-prefetch", IDS_FLAGS_NOSTATE_PREFETCH,
2127 IDS_FLAGS_NOSTATE_PREFETCH_DESCRIPTION, kOsAll, 2127 IDS_FLAGS_NOSTATE_PREFETCH_DESCRIPTION, kOsAll,
2128 FEATURE_WITH_VARIATIONS_VALUE_TYPE(prerender::kNoStatePrefetchFeature, 2128 FEATURE_WITH_VARIATIONS_VALUE_TYPE(prerender::kNoStatePrefetchFeature,
2129 kNoStatePrefetchFeatureVariations, 2129 kNoStatePrefetchFeatureVariations,
2130 "NoStatePrefetchValidation")}, 2130 "NoStatePrefetchValidation")},
2131 #if defined(OS_CHROMEOS) 2131 #if defined(OS_CHROMEOS)
2132 {"cros-comp-updates", IDS_FLAGS_CROS_COMP_UPDATES_NAME, 2132 {"cros-comp-updates", IDS_FLAGS_CROS_COMP_UPDATES_NAME,
2133 IDS_FLAGS_CROS_COMP_UPDATES_DESCRIPTION, kOsCrOS, 2133 IDS_FLAGS_CROS_COMP_UPDATES_DESCRIPTION, kOsCrOS,
2134 FEATURE_VALUE_TYPE(features::kCrosCompUpdates)}, 2134 FEATURE_VALUE_TYPE(features::kCrosCompUpdates)},
2135 #endif 2135 #endif
2136
2137 #if defined(OS_ANDROID) 2136 #if defined(OS_ANDROID)
2138 {"enable-expanded-autofill-credit-card-popup", 2137 {"enable-expanded-autofill-credit-card-popup",
2139 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT, 2138 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT,
2140 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION, 2139 IDS_FLAGS_ENABLE_EXPANDED_AUTOFILL_CREDIT_CARD_POPUP_LAYOUT_DESCRIPTION,
2141 kOsAndroid, 2140 kOsAndroid,
2142 FEATURE_WITH_VARIATIONS_VALUE_TYPE( 2141 FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2143 autofill::kAutofillCreditCardPopupLayout, 2142 autofill::kAutofillCreditCardPopupLayout,
2144 kAutofillCreditCardPopupLayoutFeatureVariations, 2143 kAutofillCreditCardPopupLayoutFeatureVariations,
2145 "AutofillCreditCardPopupLayout")}, 2144 "AutofillCreditCardPopupLayout")},
2146 #endif // OS_ANDROID 2145 #endif // OS_ANDROID
2146 {"enable-faster-location-reload", IDS_FLAGS_FASTER_LOCATION_RELOAD_NAME,
2147 IDS_FLAGS_FASTER_LOCATION_RELOAD_DESCRIPTION, kOsAll,
2148 FEATURE_VALUE_TYPE(features::kFasterLocationReload)}
2147 2149
2148 // NOTE: Adding new command-line switches requires adding corresponding 2150 // NOTE: Adding new command-line switches requires adding corresponding
2149 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2151 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2150 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2152 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2151 }; 2153 };
2152 2154
2153 class FlagsStateSingleton { 2155 class FlagsStateSingleton {
2154 public: 2156 public:
2155 FlagsStateSingleton() 2157 FlagsStateSingleton()
2156 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2158 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
2346 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2348 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2347 2349
2348 const FeatureEntry* GetFeatureEntries(size_t* count) { 2350 const FeatureEntry* GetFeatureEntries(size_t* count) {
2349 *count = arraysize(kFeatureEntries); 2351 *count = arraysize(kFeatureEntries);
2350 return kFeatureEntries; 2352 return kFeatureEntries;
2351 } 2353 }
2352 2354
2353 } // namespace testing 2355 } // namespace testing
2354 2356
2355 } // namespace about_flags 2357 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/child/runtime_features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698