DevTools: kill SDK.CSSParser

DevTools: kill SDK.CSSParser

This abstraction is not needed any more. All the clients are migrated
over to the Common.FormatterWorkerPool.parseCSS method.

BUG=none
R=dgozman

Committed: https://crrev.com/f824367e4d2e9e81184179871d4dd26ce03ad359
Cr-Commit-Position: refs/heads/master@{#438747}

[lushnikov, 2016-12-14 07:28:20]

please, take a look

[lushnikov, 2016-12-14 07:28:24]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 07:28:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:30:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 07:30:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[lushnikov, 2016-12-14 08:29:48]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 08:30:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 08:31:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 08:31:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dgozman, 2016-12-14 19:05:02]

lgtm

https://codereview.chromium.org/2572053002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js
(right):

https://codereview.chromium.org/2572053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js:40:
this._rules = [];
Let's @type this for compiler to kick-in.

https://codereview.chromium.org/2572053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js:42:
this._rules.push(...rules);
Are you sure this is safe to do?

[lushnikov, 2016-12-15 00:28:46]

https://codereview.chromium.org/2572053002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js
(right):

https://codereview.chromium.org/2572053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js:40:
this._rules = [];
On 2016/12/14 19:05:02, dgozman wrote:
> Let's @type this for compiler to kick-in.

Done.

https://codereview.chromium.org/2572053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js:42:
this._rules.push(...rules);
On 2016/12/14 19:05:02, dgozman wrote:
> Are you sure this is safe to do?

The feature has hit stable and looks simple. Should be fine!

[lushnikov, 2016-12-15 00:29:08]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 00:29:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:33:18]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[lushnikov, 2016-12-15 03:22:50]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-15 03:22:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2572053002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-15 03:23:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:52:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481772170740930,
"parent_rev": "5d93b65a59ec232857dd90c57275c3f768ba1ec9", "commit_rev":
"c96154e44680b0129bec9dbb8cb2b22e16b2fcb3"}

[commit-bot: I haz the power, 2016-12-15 04:52:38]

Description was changed from

==========
DevTools: kill SDK.CSSParser

This abstraction is not needed any more. All the clients are migrated
over to the Common.FormatterWorkerPool.parseCSS method.

BUG=none
R=dgozman
==========

to

==========
DevTools: kill SDK.CSSParser

This abstraction is not needed any more. All the clients are migrated
over to the Common.FormatterWorkerPool.parseCSS method.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2572053002
==========

[commit-bot: I haz the power, 2016-12-15 04:52:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 04:54:51]

Description was changed from

==========
DevTools: kill SDK.CSSParser

This abstraction is not needed any more. All the clients are migrated
over to the Common.FormatterWorkerPool.parseCSS method.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2572053002
==========

to

==========
DevTools: kill SDK.CSSParser

This abstraction is not needed any more. All the clients are migrated
over to the Common.FormatterWorkerPool.parseCSS method.

BUG=none
R=dgozman

Committed: https://crrev.com/f824367e4d2e9e81184179871d4dd26ce03ad359
Cr-Commit-Position: refs/heads/master@{#438747}
==========

[commit-bot: I haz the power, 2016-12-15 04:54:52]

Patchset 3 (id:??) landed as
https://crrev.com/f824367e4d2e9e81184179871d4dd26ce03ad359
Cr-Commit-Position: refs/heads/master@{#438747}