DevTools: introduce API for the Common.FormatterWorkerPool.

DevTools: introduce API for the Common.FormatterWorkerPool.

Currently, the Common.FormatterWorkerPool provides two methods:
- runTask
- runChunkedTask

This is very low-level. In fact, FormatterWorkerPool is a front-end for
formatter workers; it makes sense to introduce an API which will describe
functionality of the worker.

BUG=none
R=dgozman

Committed: https://crrev.com/04bdec650bdff2140ab3f7154a63d52d97318c53
Cr-Commit-Position: refs/heads/master@{#438699}

[lushnikov, 2016-12-14 05:15:40]

please, take a lok

[lushnikov, 2016-12-14 05:15:44]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 05:16:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:48:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 07:48:46]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-12-14 08:29:12]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 08:29:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 10:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 10:10:30]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-14 19:33:00]

Let's move it to it's own module in a follow-up.

lgtm

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js
(right):

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:98: *
@return {!Promise<?Object>}
*

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:111:
* @return {!Promise<?Object>}
*

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:113:
relaxedJSONParser(content) {
parseJSONRelaxed

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:119:
* @return {!Promise<!Array<!Object>>}
Let's add types.

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
(right):

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js:38:
this._functionItems = this._functionItems.concat(items);
@lushnikov: tell me to use spread operator.

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js
(right):

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js:93: *
@param {?{content: string, mapping: !{original: !Array<number>, formatted:
!Array<number>}}} data
FormatResult?

[lushnikov, 2016-12-14 23:36:56]

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js
(right):

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:98: *
@return {!Promise<?Object>}
On 2016/12/14 19:32:59, dgozman wrote:
> *

Done.

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:111:
* @return {!Promise<?Object>}
On 2016/12/14 19:32:59, dgozman wrote:
> *

Done.

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:113:
relaxedJSONParser(content) {
On 2016/12/14 19:32:59, dgozman wrote:
> parseJSONRelaxed

Done.

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js:119:
* @return {!Promise<!Array<!Object>>}
On 2016/12/14 19:32:59, dgozman wrote:
> Let's add types.

Done.

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
(right):

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js:38:
this._functionItems = this._functionItems.concat(items);
On 2016/12/14 19:33:00, dgozman wrote:
> @lushnikov: tell me to use spread operator.

Done.

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js
(right):

https://codereview.chromium.org/2570263002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatter.js:93: *
@param {?{content: string, mapping: !{original: !Array<number>, formatted:
!Array<number>}}} data
On 2016/12/14 19:33:00, dgozman wrote:
> FormatResult?

Done.

[lushnikov, 2016-12-14 23:47:06]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-14 23:47:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2570263002/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-14 23:47:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 01:19:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481759226773470,
"parent_rev": "85582c9e0da7fa849c9341407f6fdeaea4edf889", "commit_rev":
"821922b9d600dab90ac1b84508a77c911feb2acd"}

[commit-bot: I haz the power, 2016-12-15 01:19:42]

Description was changed from

==========
DevTools: introduce API for the Common.FormatterWorkerPool.

Currently, the Common.FormatterWorkerPool provides two methods:
- runTask
- runChunkedTask

This is very low-level. In fact, FormatterWorkerPool is a front-end for
formatter workers; it makes sense to introduce an API which will describe
functionality of the worker.

BUG=none
R=dgozman
==========

to

==========
DevTools: introduce API for the Common.FormatterWorkerPool.

Currently, the Common.FormatterWorkerPool provides two methods:
- runTask
- runChunkedTask

This is very low-level. In fact, FormatterWorkerPool is a front-end for
formatter workers; it makes sense to introduce an API which will describe
functionality of the worker.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2570263002
==========

[commit-bot: I haz the power, 2016-12-15 01:19:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-15 01:23:40]

Description was changed from

==========
DevTools: introduce API for the Common.FormatterWorkerPool.

Currently, the Common.FormatterWorkerPool provides two methods:
- runTask
- runChunkedTask

This is very low-level. In fact, FormatterWorkerPool is a front-end for
formatter workers; it makes sense to introduce an API which will describe
functionality of the worker.

BUG=none
R=dgozman

Review-Url: https://codereview.chromium.org/2570263002
==========

to

==========
DevTools: introduce API for the Common.FormatterWorkerPool.

Currently, the Common.FormatterWorkerPool provides two methods:
- runTask
- runChunkedTask

This is very low-level. In fact, FormatterWorkerPool is a front-end for
formatter workers; it makes sense to introduce an API which will describe
functionality of the worker.

BUG=none
R=dgozman

Committed: https://crrev.com/04bdec650bdff2140ab3f7154a63d52d97318c53
Cr-Commit-Position: refs/heads/master@{#438699}
==========

[commit-bot: I haz the power, 2016-12-15 01:23:41]

Patchset 4 (id:??) landed as
https://crrev.com/04bdec650bdff2140ab3f7154a63d52d97318c53
Cr-Commit-Position: refs/heads/master@{#438699}