Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2571863002: Remove unused flags in CFWL_PushButton (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -55 lines) Patch
M xfa/fwl/cfwl_pushbutton.h View 1 chunk +0 lines, -13 lines 0 comments Download
M xfa/fwl/cfwl_pushbutton.cpp View 1 chunk +1 line, -42 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
dsinclair
PTAL. https://codereview.chromium.org/2571863002/diff/1/xfa/fwl/cfwl_pushbutton.cpp File xfa/fwl/cfwl_pushbutton.cpp (left): https://codereview.chromium.org/2571863002/diff/1/xfa/fwl/cfwl_pushbutton.cpp#oldcode112 xfa/fwl/cfwl_pushbutton.cpp:112: case FWL_STYLEEXT_PSB_Left | FWL_STYLEEXT_PSB_Top: { Left and Top ...
4 years ago (2016-12-13 19:17:22 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-13 19:24:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571863002/40001
4 years ago (2016-12-14 22:02:49 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-14 22:25:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/c7739322e5cdcc5779bdde2a1560ea3dee89...

Powered by Google App Engine
This is Rietveld 408576698