WindowAnimationWorklet should use ContextLifecycleObserver instead of DOMWindowProperty

WindowAnimationWorklet should use ContextLifecycleObserver instead of DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176
Committed: https://crrev.com/45369974f8ad223059462980229a9735e6ee6865
Cr-Commit-Position: refs/heads/master@{#438544}

[haraken, 2016-12-13 09:25:57]

haraken@chromium.org changed reviewers:
+ kinuko@chromium.org, nhiroki@chromium.org

[haraken, 2016-12-13 09:25:58]

kinuko@, nhiroki@: PTAL

This CL will be correct if WindowAnimationWorklet doesn't have the complicated
issue we're discussing in the NavigatorServiceWorker CL
(https://codereview.chromium.org/2556893003/).

[nhiroki, 2016-12-13 09:49:01]

https://codereview.chromium.org/2571753002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp
(left):

https://codereview.chromium.org/2571753002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp:42:
void WindowAnimationWorklet::frameDestroyed() {
This was added to fix memory leak:
https://codereview.chromium.org/2482393002/

Was the root cause already fixed?

[haraken, 2016-12-14 12:49:46]

Description was changed from

==========
Remove DOMWindowProperty from WindowAnimationWorklet

I don't see any reason we have to recreate m_animationWorklet
when the frame navigates from a same-origin initial empty page.
This CL removes the code and removes DOMWindowProperty from
WindowAnimationWorklet.

BUG=610176
==========

to

==========
WindowAnimationWorklet should use ContextLifecycleObserver instead of
DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with
ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176
==========

[haraken, 2016-12-14 12:50:48]

On 2016/12/13 09:49:01, nhiroki (OOO Dec 14 16) wrote:
>
https://codereview.chromium.org/2571753002/diff/1/third_party/WebKit/Source/m...
> File
> third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp
> (left):
> 
>
https://codereview.chromium.org/2571753002/diff/1/third_party/WebKit/Source/m...
>
third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp:42:
> void WindowAnimationWorklet::frameDestroyed() {
> This was added to fix memory leak:
> https://codereview.chromium.org/2482393002/
> 
> Was the root cause already fixed?

Thanks, I realized that WindowAnimationWorklet::frameDestroyed is still needed
to prevent the leak.

Updated the CL with a good comment. PTAL.

[kinuko, 2016-12-14 13:48:43]

lgtm

[haraken, 2016-12-14 15:35:27]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-14 15:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 18:36:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481729727019940,
"parent_rev": "c1f5357fa6e3e6324f1c680ad9019fe3454e9b39", "commit_rev":
"1141d05c6719e5a78b33782d2fe62e523ccd92cb"}

[commit-bot: I haz the power, 2016-12-14 18:37:15]

Description was changed from

==========
WindowAnimationWorklet should use ContextLifecycleObserver instead of
DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with
ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176
==========

to

==========
WindowAnimationWorklet should use ContextLifecycleObserver instead of
DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with
ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2571753002
==========

[commit-bot: I haz the power, 2016-12-14 18:37:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-14 18:40:21]

Description was changed from

==========
WindowAnimationWorklet should use ContextLifecycleObserver instead of
DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with
ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2571753002
==========

to

==========
WindowAnimationWorklet should use ContextLifecycleObserver instead of
DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with
ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176

Committed: https://crrev.com/45369974f8ad223059462980229a9735e6ee6865
Cr-Commit-Position: refs/heads/master@{#438544}
==========

[commit-bot: I haz the power, 2016-12-14 18:40:22]

Patchset 2 (id:??) landed as
https://crrev.com/45369974f8ad223059462980229a9735e6ee6865
Cr-Commit-Position: refs/heads/master@{#438544}

[nhiroki, 2016-12-15 00:59:54]

LGTM. Thank you for adding the nice comment :)