[worklets] Fixes leak document leak for AnimationWorklet.

[worklets] Fixes leak document leak for AnimationWorklet.

It looks like this may have been a reference cycle between Document
and AnimationWorklet.

AnimationWorklet had a ThreadedMessagingProxyBase which held a
persistent to Document. (ThreadedMessagingProxyBase was a raw pointer).

The AnimationWorklet destructor was never being called at the right time
to destroy the ThreadedMessagingProxyBase.

Test:
./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default --additional-driver-flag=--enable-leak-detection  third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html

BUG=652535
Committed: https://crrev.com/643218b3cc1e809e8fbb5f23e1300d18a676dff4
Cr-Commit-Position: refs/heads/master@{#431081}

[ikilpatrick, 2016-11-09 06:33:55]

Description was changed from

==========
[worklets] Fixes leak document leak for AnimationWorklet.

It looks like this may have been a reference cycle between Document
and AnimationWorklet.

AnimationWorklet had a ThreadedMessagingProxyBase which held a
persistent to Document. (ThreadedMessagingProxyBase was a raw pointer).

The AnimationWorklet destructor was never being called at the right time
to destroy the ThreadedMessagingProxyBase.

BUG=652535
==========

to

==========
[worklets] Fixes leak document leak for AnimationWorklet.

It looks like this may have been a reference cycle between Document
and AnimationWorklet.

AnimationWorklet had a ThreadedMessagingProxyBase which held a
persistent to Document. (ThreadedMessagingProxyBase was a raw pointer).

The AnimationWorklet destructor was never being called at the right time
to destroy the ThreadedMessagingProxyBase.

Test:
./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default
--additional-driver-flag=--enable-leak-detection 
third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html

BUG=652535
==========

[ikilpatrick, 2016-11-09 06:36:34]

ikilpatrick@chromium.org changed reviewers:
+ haraken@chromium.org, nhiroki@chromium.org

[ikilpatrick, 2016-11-09 06:36:34]

This fixes on my local machine so it'll be interesting to see if this works for
the bot.

I'm a bit confused as to why the explicit clear is needed as thought that
DOMWindowProperty was WeakMember?

[ikilpatrick, 2016-11-09 06:36:43]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-09 06:36:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-11-09 06:40:02]

On 2016/11/09 06:36:34, ikilpatrick wrote:
> This fixes on my local machine so it'll be interesting to see if this works
for
> the bot.
> 
> I'm a bit confused as to why the explicit clear is needed as thought that
> DOMWindowProperty was WeakMember?

LGTM.

Maybe m_animationWorklet was keeping alive something that keeps alive document?

[nhiroki, 2016-11-09 06:51:57]

LGTM :)

[commit-bot: I haz the power, 2016-11-09 08:18:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 08:18:27]

Dry run: This issue passed the CQ dry run.

[nhiroki, 2016-11-09 09:54:25]

On 2016/11/09 06:51:57, nhiroki wrote:
> LGTM :)

FYI: I confirmed my CL[1] doesn't cause a memory leak on my local env after this
CL.

[1] https://codereview.chromium.org/2456733002/

[ikilpatrick, 2016-11-09 23:31:45]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2016-11-09 23:32:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 23:41:08]

Description was changed from

==========
[worklets] Fixes leak document leak for AnimationWorklet.

It looks like this may have been a reference cycle between Document
and AnimationWorklet.

AnimationWorklet had a ThreadedMessagingProxyBase which held a
persistent to Document. (ThreadedMessagingProxyBase was a raw pointer).

The AnimationWorklet destructor was never being called at the right time
to destroy the ThreadedMessagingProxyBase.

Test:
./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default
--additional-driver-flag=--enable-leak-detection 
third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html

BUG=652535
==========

to

==========
[worklets] Fixes leak document leak for AnimationWorklet.

It looks like this may have been a reference cycle between Document
and AnimationWorklet.

AnimationWorklet had a ThreadedMessagingProxyBase which held a
persistent to Document. (ThreadedMessagingProxyBase was a raw pointer).

The AnimationWorklet destructor was never being called at the right time
to destroy the ThreadedMessagingProxyBase.

Test:
./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default
--additional-driver-flag=--enable-leak-detection 
third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html

BUG=652535
==========

[commit-bot: I haz the power, 2016-11-09 23:41:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-09 23:51:14]

Description was changed from

==========
[worklets] Fixes leak document leak for AnimationWorklet.

It looks like this may have been a reference cycle between Document
and AnimationWorklet.

AnimationWorklet had a ThreadedMessagingProxyBase which held a
persistent to Document. (ThreadedMessagingProxyBase was a raw pointer).

The AnimationWorklet destructor was never being called at the right time
to destroy the ThreadedMessagingProxyBase.

Test:
./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default
--additional-driver-flag=--enable-leak-detection 
third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html

BUG=652535
==========

to

==========
[worklets] Fixes leak document leak for AnimationWorklet.

It looks like this may have been a reference cycle between Document
and AnimationWorklet.

AnimationWorklet had a ThreadedMessagingProxyBase which held a
persistent to Document. (ThreadedMessagingProxyBase was a raw pointer).

The AnimationWorklet destructor was never being called at the right time
to destroy the ThreadedMessagingProxyBase.

Test:
./third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default
--additional-driver-flag=--enable-leak-detection 
third_party/WebKit/LayoutTests/virtual/threaded/http/tests/worklet/animation-worklet-import.html

BUG=652535

Committed: https://crrev.com/643218b3cc1e809e8fbb5f23e1300d18a676dff4
Cr-Commit-Position: refs/heads/master@{#431081}
==========

[commit-bot: I haz the power, 2016-11-09 23:51:15]

Patchset 1 (id:??) landed as
https://crrev.com/643218b3cc1e809e8fbb5f23e1300d18a676dff4
Cr-Commit-Position: refs/heads/master@{#431081}