Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2571723002: Revert of android: Randomize initial child service bind order (Closed)

Created:
4 years ago by boliu
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Randomize initial child service bind order (patchset #3 id:40001 of https://codereview.chromium.org/2557273004/ ) Reason for revert: Android keeps the intent for a long time, so randomize doesn't help at all. More details: crbug.com/664341#c91 Original issue's description: > android: Randomize initial child service bind order > > Android restarts crashed services with the previous intent. > If browser crashes and is restarted at the same time, then > it's possible to bind to the restarted service with stale > intent and bundle data. See crbug.com/664341#c83 for an > example. Randomizing the start up order is a pure > workaround to make this case less likely. > > BUG=664341 > > Committed: https://crrev.com/bb725fed9bd8c672178c8a815f4b1a2500eef444 > Cr-Commit-Position: refs/heads/master@{#437367} TBR=agrieve@chromium.org,jcivelli@chromium.org,mariakhomenko@chromium.org,hanxi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=664341 Committed: https://crrev.com/2e30a3dfda9367264173c8707bbc22d7530f7a77 Cr-Commit-Position: refs/heads/master@{#438042}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
boliu
Created Revert of android: Randomize initial child service bind order
4 years ago (2016-12-13 03:00:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2571723002/1
4 years ago (2016-12-13 03:01:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 03:49:31 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-13 03:52:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e30a3dfda9367264173c8707bbc22d7530f7a77
Cr-Commit-Position: refs/heads/master@{#438042}

Powered by Google App Engine
This is Rietveld 408576698