Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java

Issue 2571723002: Revert of android: Randomize initial child service bind order (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
index d6a45d46651eb7dfa13982b1e99b5ceaa2f89239..1f10e35d521aec9740ecf8df92169a3a1d5c90ac 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
@@ -250,16 +250,20 @@
// Start and connect to a new service of an external APK.
ChildProcessConnectionImpl externalApkConnection =
allocateConnection(EXTERNAL_APK_PACKAGE_NAME);
- assertNotNull(externalApkConnection);
// Start and connect to a new service for a regular tab.
ChildProcessConnectionImpl tabConnection = allocateConnection(appContext.getPackageName());
- assertNotNull(tabConnection);
// Verify that one connection is allocated for an external APK and a regular tab
// respectively.
assertEquals(1, ChildProcessLauncher.allocatedSandboxedConnectionsCountForTesting(
appContext, EXTERNAL_APK_PACKAGE_NAME));
assertEquals(1, allocatedChromeSandboxedConnectionsCount());
+
+ // Verify that connections allocated for an external APK and the regular tab are from
+ // different ChildConnectionAllocators, since both ChildConnectionAllocators start
+ // allocating connections from number 0.
+ assertEquals(0, externalApkConnection.getServiceNumber());
+ assertEquals(0, tabConnection.getServiceNumber());
}
/**
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698