DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes

DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes

This patch does two things:
- do not suggest SVG properties for non-svg nodes in StylesSidebarPane
- suggest only SVG properties for SVG nodes

BUG=389577
R=dgozman

Committed: https://crrev.com/701e91a6709bb7849e51c8597da8e754079087e6
Cr-Commit-Position: refs/heads/master@{#438101}

[lushnikov, 2016-12-13 02:49:02]

please, take a look

[lushnikov, 2016-12-13 02:49:11]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 02:50:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-12-13 03:16:46]

lgtm

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/browser_protocol.json:2028: { "name":
"isSVG", "type": "boolean", "optional": true, "description": "Whether the node
is from SVG document.", "experimental": true }
incorrect description

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:152: isSVG() {
isSVGNode

[commit-bot: I haz the power, 2016-12-13 04:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:37:43]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-12-13 07:05:31]

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/browser_protocol.json:2028: { "name":
"isSVG", "type": "boolean", "optional": true, "description": "Whether the node
is from SVG document.", "experimental": true }
On 2016/12/13 03:16:46, dgozman wrote:
> incorrect description

Done.

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js (right):

https://codereview.chromium.org/2571713002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js:152: isSVG() {
On 2016/12/13 03:16:46, dgozman wrote:
> isSVGNode

Done.

[lushnikov, 2016-12-13 07:05:38]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-13 07:05:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2571713002/#ps20001
(title: "addres comments")

[commit-bot: I haz the power, 2016-12-13 07:05:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 08:35:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481612738684780,
"parent_rev": "0cc7d81f7c64bd22b92bccdbfa5f5080befb1054", "commit_rev":
"4196622c5d84f403eb572ab2087c89452e5849d3"}

[commit-bot: I haz the power, 2016-12-13 08:35:48]

Description was changed from

==========
DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes

This patch does two things:
- do not suggest SVG properties for non-svg nodes in StylesSidebarPane
- suggest only SVG properties for SVG nodes

BUG=389577
R=dgozman
==========

to

==========
DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes

This patch does two things:
- do not suggest SVG properties for non-svg nodes in StylesSidebarPane
- suggest only SVG properties for SVG nodes

BUG=389577
R=dgozman

Review-Url: https://codereview.chromium.org/2571713002
==========

[commit-bot: I haz the power, 2016-12-13 08:35:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 08:37:37]

Description was changed from

==========
DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes

This patch does two things:
- do not suggest SVG properties for non-svg nodes in StylesSidebarPane
- suggest only SVG properties for SVG nodes

BUG=389577
R=dgozman

Review-Url: https://codereview.chromium.org/2571713002
==========

to

==========
DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes

This patch does two things:
- do not suggest SVG properties for non-svg nodes in StylesSidebarPane
- suggest only SVG properties for SVG nodes

BUG=389577
R=dgozman

Committed: https://crrev.com/701e91a6709bb7849e51c8597da8e754079087e6
Cr-Commit-Position: refs/heads/master@{#438101}
==========

[commit-bot: I haz the power, 2016-12-13 08:37:38]

Patchset 2 (id:??) landed as
https://crrev.com/701e91a6709bb7849e51c8597da8e754079087e6
Cr-Commit-Position: refs/heads/master@{#438101}

[PhistucK, 2016-12-13 08:43:51]

phistuck@gmail.com changed reviewers:
+ phistuck@gmail.com

[PhistucK, 2016-12-13 08:43:51]

https://codereview.chromium.org/2571713002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2571713002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:2328:
cssCompletions.filter(property => SDK.cssMetadata().isSVGProperty(property) ===
this.node().isSVGNode());
Ouch! This seems very unnecessarily unfriendly to performance, can you just
store this.node().isSVGNode() in a const and use it instead?

I would say the same for SDK.cssMetadata(), but that might be a very simple
method (though the look-up-and-call is still more expensive than just getting it
from a variable).