third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp - Issue 2571713002: DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 2571713002: DevTools: [SSP] do not autocomplete SVG properties for non-svg nodes (Closed)

Patch Set: addres comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

index da950b94dfce28730bfa4c21670e0a73d3374ee1..18245a23a3f1a1a4b02e141109107bfbc02ef1a5 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1576,6 +1576,9 @@ std::unique_ptr<protocol::DOM::Node> InspectorDOMAgent::buildObjectForNode(

.setNodeValue(nodeValue)

.build();

+ if (node->isSVGElement())

+ value->setIsSVG(true);

bool forcePushChildren = false;

if (node->isElementNode()) {

Element* element = toElement(node);