[Downloads] Various fixes

[Downloads] Various fixes

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

* Disallow long pressing on an incomplete file in Download Home.

BUG=658246, 658742
Committed: https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6
Cr-Commit-Position: refs/heads/master@{#438600}

[gone, 2016-12-12 22:48:26]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2016-12-12 22:48:27]

Code's mainly moving around, but the DownloadNotificationService changes could
use a more careful eye because it's Min's code and I've added the ability to
click on notifications.

[Theresa, 2016-12-13 17:44:44]

lgtm

[gone, 2016-12-14 18:54:38]

Description was changed from

==========
[Downloads] Notification click sends users to Download Home

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

BUG=658246,658742
==========

to

==========
[Downloads] Various fixes

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

* Disallow long pressing on an incomplete file in Download Home.

BUG=658246,658742
==========

[gone, 2016-12-14 18:55:39]

Eh heh... didn't realize you'd lgtmed this already.  I added another fix to it. 
PTAL when you get a chance.

[gone, 2016-12-14 18:57:50]

Got a verbal still lgtm; landing

[gone, 2016-12-14 18:57:56]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-12-14 18:57:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2571623002/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-12-14 18:58:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 19:52:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481741876983410,
"parent_rev": "5f2376dc4ab6884be492a82b370833e15780e812", "commit_rev":
"2fa489c26b53d35cce789dda5c1ffdb94bb09e0c"}

[commit-bot: I haz the power, 2016-12-14 19:53:08]

Description was changed from

==========
[Downloads] Various fixes

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

* Disallow long pressing on an incomplete file in Download Home.

BUG=658246,658742
==========

to

==========
[Downloads] Various fixes

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

* Disallow long pressing on an incomplete file in Download Home.

BUG=658246,658742

Review-Url: https://codereview.chromium.org/2571623002
==========

[commit-bot: I haz the power, 2016-12-14 19:53:09]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-14 19:55:43]

Description was changed from

==========
[Downloads] Various fixes

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

* Disallow long pressing on an incomplete file in Download Home.

BUG=658246,658742

Review-Url: https://codereview.chromium.org/2571623002
==========

to

==========
[Downloads] Various fixes

* Clicking on an in-progress or paused download now sends the
  user to Download Home instead of doing nothing.  This uses
  the existing Intent broadcasting mechanism, using a lack of
  download IDs in the Intent as a signal that Download Home
  should be opened instead.

* Unifies the DownloadBroadCastReceiver and DownloadManagerService
  pathways for opening a download.  This also fixes an assert that
  called a method on the UI thread instead of in the background.

* Failing to open a download now sends the user to Download
  Home instead of silently failing.

* Cleans up some code in DownloadNotificationService.

* Prevents showing unresumable files in Download Home.  This
  happens if the user tries to download a file that is "interrupted"
  when a file doesn't exist (e.g.).

* Disallow long pressing on an incomplete file in Download Home.

BUG=658246,658742

Committed: https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6
Cr-Commit-Position: refs/heads/master@{#438600}
==========

[commit-bot: I haz the power, 2016-12-14 19:55:44]

Patchset 4 (id:??) landed as
https://crrev.com/fc7b3f9fb992b7bab8f1130a68afb55c7c8259f6
Cr-Commit-Position: refs/heads/master@{#438600}