chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java - Issue 2571623002: [Downloads] Various fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

Issue 2571623002: [Downloads] Various fixes (Closed)

Patch Set: Rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

index 82382d0ceed0357eae524f2146e57aa6ebc3e31d..ff98a16652db5dc9ef98c1c2841bc716f13b13b4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

@@ -395,7 +395,11 @@ public abstract class DownloadHistoryItemWrapper extends TimedItem {

return false;

}

- if (mItem.getDownloadInfo().state() == DownloadState.CANCELLED) {

+ int state = mItem.getDownloadInfo().state();

+ if ((state == DownloadState.INTERRUPTED && !mItem.getDownloadInfo().isResumable())

+ || state == DownloadState.CANCELLED) {

+ // Mocks don't include showing cancelled/unresumable downloads. Might need to if

+ // undeletable files become a big issue.

return false;

}