Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Issue 25716003: Make it explicit that some validate methods are debug only ... (Closed)

Created:
7 years, 2 months ago by robertphillips
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

... lest some compiler slap you with an empty function call if you have the temerity to put the method body in a .cpp (crbug.com/302570).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -44 lines) Patch
M include/core/SkPathRef.h View 10 chunks +17 lines, -17 lines 0 comments Download
M include/core/SkRefCnt.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkWeakRefCnt.h View 1 chunk +3 lines, -1 line 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkPathRef.cpp View 13 chunks +20 lines, -17 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 2 months ago (2013-10-02 14:57:18 UTC) #1
bsalomon
lgtm
7 years, 2 months ago (2013-10-02 15:19:57 UTC) #2
robertphillips
7 years, 2 months ago (2013-10-02 16:51:11 UTC) #3
Message was sent while issue was closed.
committed in r11575

Powered by Google App Engine
This is Rietveld 408576698