Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2571583002:
[DevTools] Rendering option description cleanup (Closed)
|
Created:
4 years ago by phulce Modified:
4 years ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Rendering option description cleanup
Removes the lone tooltip on 'Scrolling Performance Issues'.
Clarifies the description of 'Scrolling Performance Issues'.
Adds color information to the 'Paint Flashing' option.
BUG=614977
Committed: https://crrev.com/7d47b5f2d7c29376416ab91af5c5ef84452cbefa
Cr-Commit-Position: refs/heads/master@{#438271}
Patch Set 1 #
Total comments: 4
Patch Set 2 : cleanup tooltip remnants #Messages
Total messages: 17 (8 generated)
Description was changed from ========== [DevTools] Rendering option description cleanup BUG= ========== to ========== [DevTools] Rendering option description cleanup Removes the lone tooltip on 'Scrolling Performance Issues'. Clarifies the description of 'Scrolling Performance Issues'. Adds color information to the 'Paint Flashing' option. BUG=614977 ==========
phulce@chromium.org changed reviewers: + dgozman@chromium.org
Messaging decided on after discussion with chowse and paulirish.
https://codereview.chromium.org/2571583002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js (right): https://codereview.chromium.org/2571583002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js:65: this._appendCheckbox(options[i].label, options[i].setterName, options[i].subtitle, options[i].tooltip); Remove tooltip from here. https://codereview.chromium.org/2571583002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js:100: _appendCheckbox(label, setterName, subtitle, tooltip) { And from here.
https://codereview.chromium.org/2571583002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js (right): https://codereview.chromium.org/2571583002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js:65: this._appendCheckbox(options[i].label, options[i].setterName, options[i].subtitle, options[i].tooltip); On 2016/12/12 22:50:19, dgozman wrote: > Remove tooltip from here. Done. https://codereview.chromium.org/2571583002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js:100: _appendCheckbox(label, setterName, subtitle, tooltip) { On 2016/12/12 22:50:19, dgozman wrote: > And from here. Done.
lgtm. Thanks!
The CQ bit was checked by phulce@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by phulce@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481655681474430,
"parent_rev": "0c47e25913f1ca6cfbbd876220c8cedb9d74f223", "commit_rev":
"b09db807d0bd9dbc075bae430a1c5a825536dda2"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Rendering option description cleanup Removes the lone tooltip on 'Scrolling Performance Issues'. Clarifies the description of 'Scrolling Performance Issues'. Adds color information to the 'Paint Flashing' option. BUG=614977 ========== to ========== [DevTools] Rendering option description cleanup Removes the lone tooltip on 'Scrolling Performance Issues'. Clarifies the description of 'Scrolling Performance Issues'. Adds color information to the 'Paint Flashing' option. BUG=614977 Review-Url: https://codereview.chromium.org/2571583002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Rendering option description cleanup Removes the lone tooltip on 'Scrolling Performance Issues'. Clarifies the description of 'Scrolling Performance Issues'. Adds color information to the 'Paint Flashing' option. BUG=614977 Review-Url: https://codereview.chromium.org/2571583002 ========== to ========== [DevTools] Rendering option description cleanup Removes the lone tooltip on 'Scrolling Performance Issues'. Clarifies the description of 'Scrolling Performance Issues'. Adds color information to the 'Paint Flashing' option. BUG=614977 Committed: https://crrev.com/7d47b5f2d7c29376416ab91af5c5ef84452cbefa Cr-Commit-Position: refs/heads/master@{#438271} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7d47b5f2d7c29376416ab91af5c5ef84452cbefa Cr-Commit-Position: refs/heads/master@{#438271} |
