Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js

Issue 2571583002: [DevTools] Rendering option description cleanup (Closed)
Patch Set: cleanup tooltip remnants Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js b/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
index c24678bacc62f17230da158e36b18e14e0f86699..06312696051282c80aa02c4b0807aa838748054a 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/RenderingOptions.js
@@ -42,7 +42,7 @@ Main.RenderingOptionsView = class extends UI.VBox {
var options = [
{
label: Common.UIString('Paint Flashing'),
- subtitle: Common.UIString('Highlights areas of the page that need to be repainted'),
+ subtitle: Common.UIString('Highlights areas of the page (green) that need to be repainted'),
setterName: 'setShowPaintRects'
},
{
@@ -57,14 +57,12 @@ Main.RenderingOptionsView = class extends UI.VBox {
},
{
label: Common.UIString('Scrolling Performance Issues'),
- subtitle: Common.UIString('Shows areas of the page that slow down scrolling'),
- setterName: 'setShowScrollBottleneckRects',
- tooltip:
- 'Touch and mousewheel event listeners can delay scrolling.\nSome areas need to repaint their content when scrolled.'
+ subtitle: Common.UIString('Highlights elements (teal) that can slow down scrolling, including touch & wheel event handlers and other main-thread scrolling situations.'),
+ setterName: 'setShowScrollBottleneckRects'
}
];
for (var i = 0; i < options.length; i++)
- this._appendCheckbox(options[i].label, options[i].setterName, options[i].subtitle, options[i].tooltip);
+ this._appendCheckbox(options[i].label, options[i].setterName, options[i].subtitle);
this.contentElement.createChild('div').classList.add('panel-section-separator');
@@ -97,14 +95,11 @@ Main.RenderingOptionsView = class extends UI.VBox {
* @param {string} label
* @param {string} setterName
* @param {string=} subtitle
- * @param {string=} tooltip
*/
- _appendCheckbox(label, setterName, subtitle, tooltip) {
+ _appendCheckbox(label, setterName, subtitle) {
var checkboxLabel = createCheckboxLabel(label, false, subtitle);
this._settings.set(setterName, checkboxLabel.checkboxElement);
checkboxLabel.checkboxElement.addEventListener('click', this._settingToggled.bind(this, setterName));
- if (tooltip)
- checkboxLabel.title = tooltip;
this.contentElement.appendChild(checkboxLabel);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698