Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3622)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/lkgr Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index 687dca2a90f47b1367a8f3b141ddb4acef686fd8..e4de46caaa308de9d6846273ea86b75283eef553 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -129,8 +129,7 @@ void ManagePasswordsBubbleModel::OnPasswordAction(
password_store->AddLogin(password_form);
}
-void ManagePasswordsBubbleModel::WebContentsDestroyed(
- content::WebContents* web_contents) {
+void ManagePasswordsBubbleModel::WebContentsDestroyed() {
// The WebContents have been destroyed.
web_contents_ = NULL;
jam 2014/05/02 19:34:11 please remove web_contents_ from this class and sw
zverre 2014/05/05 16:40:25 Done.
}

Powered by Google App Engine
This is Rietveld 408576698