Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 257153003: We have a problem in the process on destroying WebContentsImpl because (Closed) Base URL: https://git.chromium.org/chromium/src.git@master
Patch Set: Rebased onto origin/lkgr Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
6 6
7 #include "chrome/browser/password_manager/password_store_factory.h" 7 #include "chrome/browser/password_manager/password_store_factory.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/browser_finder.h" 9 #include "chrome/browser/ui/browser_finder.h"
10 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h" 10 #include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 password_manager::PasswordStore* password_store = 122 password_manager::PasswordStore* password_store =
123 PasswordStoreFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS) 123 PasswordStoreFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS)
124 .get(); 124 .get();
125 DCHECK(password_store); 125 DCHECK(password_store);
126 if (action == REMOVE_PASSWORD) 126 if (action == REMOVE_PASSWORD)
127 password_store->RemoveLogin(password_form); 127 password_store->RemoveLogin(password_form);
128 else 128 else
129 password_store->AddLogin(password_form); 129 password_store->AddLogin(password_form);
130 } 130 }
131 131
132 void ManagePasswordsBubbleModel::WebContentsDestroyed( 132 void ManagePasswordsBubbleModel::WebContentsDestroyed() {
133 content::WebContents* web_contents) {
134 // The WebContents have been destroyed. 133 // The WebContents have been destroyed.
135 web_contents_ = NULL; 134 web_contents_ = NULL;
jam 2014/05/02 19:34:11 please remove web_contents_ from this class and sw
zverre 2014/05/05 16:40:25 Done.
136 } 135 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698